diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2005-10-12 17:18:15 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2005-10-12 17:18:15 +0000 |
| commit | 00de66a3b4bd6ab9c42b2c9491519184d3613e54 (patch) | |
| tree | a38ccda51da3f5106c82f1925586acfddbfd6702 | |
| parent | 592ca3cf06890be74eb6ad52805aeae1ebdc4899 (diff) | |
| download | postgresql-00de66a3b4bd6ab9c42b2c9491519184d3613e54.tar.gz postgresql-00de66a3b4bd6ab9c42b2c9491519184d3613e54.zip | |
Fix longstanding bug found by Atsushi Ogawa: _bt_check_unique would mark
the wrong buffer dirty when trying to kill a dead index entry that's on
a page after the one it started on. No risk of data corruption, just
inefficiency, but still a bug.
| -rw-r--r-- | src/backend/access/nbtree/nbtinsert.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/backend/access/nbtree/nbtinsert.c b/src/backend/access/nbtree/nbtinsert.c index 3a1a4712897..1c5060c0cd3 100644 --- a/src/backend/access/nbtree/nbtinsert.c +++ b/src/backend/access/nbtree/nbtinsert.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/access/nbtree/nbtinsert.c,v 1.119 2004/12/31 21:59:22 pgsql Exp $ + * $PostgreSQL: pgsql/src/backend/access/nbtree/nbtinsert.c,v 1.119.4.1 2005/10/12 17:18:15 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -266,7 +266,10 @@ _bt_check_unique(Relation rel, BTItem btitem, Relation heapRel, hbuffer) == HEAPTUPLE_DEAD) { curitemid->lp_flags |= LP_DELETE; - SetBufferCommitInfoNeedsSave(buf); + if (nbuf != InvalidBuffer) + SetBufferCommitInfoNeedsSave(nbuf); + else + SetBufferCommitInfoNeedsSave(buf); } LockBuffer(hbuffer, BUFFER_LOCK_UNLOCK); } |