diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2024-08-11 12:24:56 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2024-08-11 12:24:56 -0400 |
| commit | 016f443648d2c92a3391d12545f06cf86cc06f5f (patch) | |
| tree | b56b8be290ed9aa56303fa6b0ed72715eb22a087 | |
| parent | adf9808fa966460f822cb8ccea424cef43f27e2b (diff) | |
| download | postgresql-016f443648d2c92a3391d12545f06cf86cc06f5f.tar.gz postgresql-016f443648d2c92a3391d12545f06cf86cc06f5f.zip | |
Suppress Coverity warnings about Asserts in get_name_for_var_field.
Coverity thinks dpns->plan could be null at these points. That
shouldn't really be possible, but it's easy enough to modify the
Asserts so they'd not core-dump if it were true.
These are new in b919a97a6. Back-patch to v13; the v12 version
of the patch didn't have these Asserts.
| -rw-r--r-- | src/backend/utils/adt/ruleutils.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c index 97716991b86..0191858bd68 100644 --- a/src/backend/utils/adt/ruleutils.c +++ b/src/backend/utils/adt/ruleutils.c @@ -7298,11 +7298,11 @@ get_name_for_var_field(Var *var, int fieldno, { char *dummy_name = palloc(32); - Assert(IsA(dpns->plan, Result)); + Assert(dpns->plan && IsA(dpns->plan, Result)); snprintf(dummy_name, 32, "f%d", fieldno); return dummy_name; } - Assert(IsA(dpns->plan, SubqueryScan)); + Assert(dpns->plan && IsA(dpns->plan, SubqueryScan)); tle = get_tle_by_resno(dpns->inner_tlist, attnum); if (!tle) @@ -7426,11 +7426,11 @@ get_name_for_var_field(Var *var, int fieldno, { char *dummy_name = palloc(32); - Assert(IsA(dpns->plan, Result)); + Assert(dpns->plan && IsA(dpns->plan, Result)); snprintf(dummy_name, 32, "f%d", fieldno); return dummy_name; } - Assert(IsA(dpns->plan, CteScan)); + Assert(dpns->plan && IsA(dpns->plan, CteScan)); tle = get_tle_by_resno(dpns->inner_tlist, attnum); if (!tle) |