diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2013-01-20 23:44:06 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2013-01-20 23:44:06 -0500 |
| commit | 01910959504912f46d5d643d692ecd2ab7eabd5d (patch) | |
| tree | 9f0aa4d176e1ea90aeb817522e55223d22a86990 | |
| parent | bed5141685cef7131fc4682ea83b4c9a691544e8 (diff) | |
| download | postgresql-01910959504912f46d5d643d692ecd2ab7eabd5d.tar.gz postgresql-01910959504912f46d5d643d692ecd2ab7eabd5d.zip | |
Fix one-byte buffer overrun in PQprintTuples().
This bug goes back to the original Postgres95 sources. Its significance
to modern PG versions is marginal, since we have not used PQprintTuples()
internally in a very long time, and it doesn't seem to have ever been
documented either. Still, it *is* exposed to client apps, so somebody
out there might possibly be using it.
Xi Wang
| -rw-r--r-- | src/interfaces/libpq/fe-print.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/interfaces/libpq/fe-print.c b/src/interfaces/libpq/fe-print.c index 1c516755d0b..a88666251f2 100644 --- a/src/interfaces/libpq/fe-print.c +++ b/src/interfaces/libpq/fe-print.c @@ -681,7 +681,6 @@ PQprintTuples(const PGresult *res, int i, j; char formatString[80]; - char *tborder = NULL; nFields = PQnfields(res); @@ -700,15 +699,15 @@ PQprintTuples(const PGresult *res, int width; width = nFields * 14; - tborder = malloc(width + 1); + tborder = (char *) malloc(width + 1); if (!tborder) { fprintf(stderr, libpq_gettext("out of memory\n")); exit(1); } - for (i = 0; i <= width; i++) + for (i = 0; i < width; i++) tborder[i] = '-'; - tborder[i] = '\0'; + tborder[width] = '\0'; fprintf(fout, "%s\n", tborder); } |