diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2017-03-07 12:05:57 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2017-03-07 12:06:07 -0500 |
| commit | 03cf2219346aa78ecd1b6d4501a7697692a43c62 (patch) | |
| tree | ef101996ba226252fb037741d0c6f8e4006b9127 | |
| parent | 95c1dbcdfffcc3a77e693c3c2759e26a01f465c8 (diff) | |
| download | postgresql-03cf2219346aa78ecd1b6d4501a7697692a43c62.tar.gz postgresql-03cf2219346aa78ecd1b6d4501a7697692a43c62.zip | |
Clean up test_ifaddrs a bit.
We customarily #include <netinet/in.h> before <arpa/inet.h>; according
to our git history (cf commit 527f8babc) there used to be platform(s)
where <arpa/inet.h> didn't compile otherwise. That's probably not
really an issue anymore, but since test_ifaddrs.c is the one and only
place in our code that's not following that rule, bring it into line.
Also remove #include <sys/socket.h>, as that's duplicative given that
libpq/ifaddr.h does so (via pqcomm.h).
In passing, add a .gitignore file so nobody accidentally commits the
test_ifaddrs executable, as I nearly did.
I see no particular need to back-patch this, as it's just neatnik-ism
considering we don't build test_ifaddrs by default, or even document
it anywhere.
| -rw-r--r-- | src/tools/ifaddrs/.gitignore | 1 | ||||
| -rw-r--r-- | src/tools/ifaddrs/test_ifaddrs.c | 3 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/tools/ifaddrs/.gitignore b/src/tools/ifaddrs/.gitignore new file mode 100644 index 00000000000..2e900325e97 --- /dev/null +++ b/src/tools/ifaddrs/.gitignore @@ -0,0 +1 @@ +/test_ifaddrs diff --git a/src/tools/ifaddrs/test_ifaddrs.c b/src/tools/ifaddrs/test_ifaddrs.c index 80b9bb02660..100359ade12 100644 --- a/src/tools/ifaddrs/test_ifaddrs.c +++ b/src/tools/ifaddrs/test_ifaddrs.c @@ -8,9 +8,8 @@ #include "postgres.h" -#include <arpa/inet.h> #include <netinet/in.h> -#include <sys/socket.h> +#include <arpa/inet.h> #include "libpq/ifaddr.h" |