diff options
| author | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2024-10-28 14:07:38 +0200 |
|---|---|---|
| committer | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2024-10-28 14:08:00 +0200 |
| commit | 07ca2d4110d474669fa03203782b5dae24f1c5c6 (patch) | |
| tree | 4c48242917078cf56506818703f4d7d813b9022f | |
| parent | 431e05181e4172415decf618ada8e91d6df995b1 (diff) | |
| download | postgresql-07ca2d4110d474669fa03203782b5dae24f1c5c6.tar.gz postgresql-07ca2d4110d474669fa03203782b5dae24f1c5c6.zip | |
Fix overflow in bsearch_arg() with more than INT_MAX elements
This was introduced in commit bfa2cee784, which replaced the old
bsearch_cmp() function we had in extended_stats.c with the current
implementation. The original discussion or commit message of
bfa2cee784 didn't mention where the new implementation came from, but
based on some googling, I'm guessing *BSD or libiberty, all of which
share this same code, with or without this fix.
Author: Ranier Vilela
Reviewed-by: Nathan Bossart
Backpatch-through: 14
Discussion: https://www.postgresql.org/message-id/CAEudQAp34o_8u6sGSVraLwuMv9F7T9hyHpePXHmRaxR2Aboi%2Bw%40mail.gmail.com
| -rw-r--r-- | src/port/bsearch_arg.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/port/bsearch_arg.c b/src/port/bsearch_arg.c index a74c5882eb7..debb9fb5e6f 100644 --- a/src/port/bsearch_arg.c +++ b/src/port/bsearch_arg.c @@ -58,8 +58,8 @@ bsearch_arg(const void *key, const void *base0, void *arg) { const char *base = (const char *) base0; - int lim, - cmp; + size_t lim; + int cmp; const void *p; for (lim = nmemb; lim != 0; lim >>= 1) |