diff options
| author | Peter Eisentraut <peter@eisentraut.org> | 2024-04-25 10:08:07 +0200 |
|---|---|---|
| committer | Peter Eisentraut <peter@eisentraut.org> | 2024-04-25 10:08:07 +0200 |
| commit | 0afa288911d5af7b0f5bd7a1aa09cdea7f02590c (patch) | |
| tree | 07e242fba3892c24484c8d81b4a001a88ac12c13 | |
| parent | aa79bde725650b4cfdce05bcc119008709590af6 (diff) | |
| download | postgresql-0afa288911d5af7b0f5bd7a1aa09cdea7f02590c.tar.gz postgresql-0afa288911d5af7b0f5bd7a1aa09cdea7f02590c.zip | |
Remove unnecessary code from be_lo_put()
A permission check is performed in be_lo_put() just after returning
from inv_open(), but the permission is already checked in inv_open(),
so we can remove the second check.
This check was added in 8d9881911f0, but then the refactoring in
ae20b23a9e7 should have removed it.
Author: Yugo NAGATA <nagata@sraoss.co.jp>
Discussion: https://www.postgresql.org/message-id/flat/20240424185932.9789628b99a49ec81b020425%40sraoss.co.jp
| -rw-r--r-- | src/backend/libpq/be-fsstubs.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/src/backend/libpq/be-fsstubs.c b/src/backend/libpq/be-fsstubs.c index 28ad1c92775..27d317dfdc0 100644 --- a/src/backend/libpq/be-fsstubs.c +++ b/src/backend/libpq/be-fsstubs.c @@ -859,18 +859,6 @@ be_lo_put(PG_FUNCTION_ARGS) lo_cleanup_needed = true; loDesc = inv_open(loOid, INV_WRITE, CurrentMemoryContext); - - /* Permission check */ - if (!lo_compat_privileges && - pg_largeobject_aclcheck_snapshot(loDesc->id, - GetUserId(), - ACL_UPDATE, - loDesc->snapshot) != ACLCHECK_OK) - ereport(ERROR, - (errcode(ERRCODE_INSUFFICIENT_PRIVILEGE), - errmsg("permission denied for large object %u", - loDesc->id))); - inv_seek(loDesc, offset, SEEK_SET); written = inv_write(loDesc, VARDATA_ANY(str), VARSIZE_ANY_EXHDR(str)); Assert(written == VARSIZE_ANY_EXHDR(str)); |