aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Dunstan <andrew@dunslane.net>2023-03-12 09:00:32 -0400
committerAndrew Dunstan <andrew@dunslane.net>2023-03-12 09:04:35 -0400
commit13196cc755982e9cbccf92be67e36d5480e73edc (patch)
treeb6aab04725f91f7096cd8fe0980fddb8a7bf79e0
parent1279414bc613316d3cb7216790bc943d5af8be70 (diff)
downloadpostgresql-13196cc755982e9cbccf92be67e36d5480e73edc.tar.gz
postgresql-13196cc755982e9cbccf92be67e36d5480e73edc.zip
Mark unsafe_tests module as not runnable with installcheck
This was an omission in the original creation of the module. Also slightly adjust some wording to avoid a double "is". Backpatch the non-meson piece of this to release 12, where the module was introduced. Discussion: https://postgr.es/m/be869e1c-8e3f-4cde-8609-212c899cccf9@dunslane.net
-rw-r--r--src/test/modules/unsafe_tests/Makefile3
-rw-r--r--src/test/modules/unsafe_tests/README2
2 files changed, 4 insertions, 1 deletions
diff --git a/src/test/modules/unsafe_tests/Makefile b/src/test/modules/unsafe_tests/Makefile
index 321252f8d51..69d12984382 100644
--- a/src/test/modules/unsafe_tests/Makefile
+++ b/src/test/modules/unsafe_tests/Makefile
@@ -2,6 +2,9 @@
REGRESS = rolenames
+# the whole point of these tests is to not run installcheck
+NO_INSTALLCHECK = 1
+
ifdef USE_PGXS
PG_CONFIG = pg_config
PGXS := $(shell $(PG_CONFIG) --pgxs)
diff --git a/src/test/modules/unsafe_tests/README b/src/test/modules/unsafe_tests/README
index a7e5b2a04f5..d9dbd038b95 100644
--- a/src/test/modules/unsafe_tests/README
+++ b/src/test/modules/unsafe_tests/README
@@ -1,6 +1,6 @@
This directory doesn't actually contain any extension module.
-What it is is a home for regression tests that we don't want to run
+Instead it is a home for regression tests that we don't want to run
during "make installcheck" because they could have side-effects that
seem undesirable for a production installation.