diff options
| author | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2013-07-23 17:38:31 -0400 |
|---|---|---|
| committer | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2013-07-23 17:38:31 -0400 |
| commit | 15fdf7302a99b0f63394bc49c2528b4731a6627e (patch) | |
| tree | 8952b824f371a8fb4ebfe766bdfd510c229015da | |
| parent | c1f51ed2960ac2678535c252072695a4a8325a92 (diff) | |
| download | postgresql-15fdf7302a99b0f63394bc49c2528b4731a6627e.tar.gz postgresql-15fdf7302a99b0f63394bc49c2528b4731a6627e.zip | |
Check for NULL result from strdup
Per Coverity Scan
| -rw-r--r-- | src/interfaces/libpq/fe-secure.c | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/src/interfaces/libpq/fe-secure.c b/src/interfaces/libpq/fe-secure.c index bb05a492968..95cf4665116 100644 --- a/src/interfaces/libpq/fe-secure.c +++ b/src/interfaces/libpq/fe-secure.c @@ -1130,7 +1130,17 @@ initialize_SSL(PGconn *conn) { /* Colon, but not in second character, treat as engine:key */ char *engine_str = strdup(conn->sslkey); - char *engine_colon = strchr(engine_str, ':'); + char *engine_colon; + + if (engine_str == NULL) + { + printfPQExpBuffer(&conn->errorMessage, + libpq_gettext("out of memory\n")); + return -1; + } + + /* cannot return NULL because we already checked before strdup */ + engine_colon = strchr(engine_str, ':'); *engine_colon = '\0'; /* engine_str now has engine name */ engine_colon++; /* engine_colon now has key name */ |