diff options
| author | David Rowley <drowley@postgresql.org> | 2023-09-14 11:27:00 +1200 |
|---|---|---|
| committer | David Rowley <drowley@postgresql.org> | 2023-09-14 11:27:00 +1200 |
| commit | 17a3f1c3475a4a31ea0af9c95efdccd07dd4247c (patch) | |
| tree | b61cbbb5565f6a3471875ecddbeeba3723bc4982 | |
| parent | a26cc0334f8b02c949b68d6ba9061eeb1fa75498 (diff) | |
| download | postgresql-17a3f1c3475a4a31ea0af9c95efdccd07dd4247c.tar.gz postgresql-17a3f1c3475a4a31ea0af9c95efdccd07dd4247c.zip | |
Fix incorrect logic in plan dependency recording
Both 50e17ad28 and 29f45e299 mistakenly tried to record a plan dependency
on a function but mistakenly inverted the OidIsValid test. This meant
that we'd record a dependency only when the function's Oid was
InvalidOid. Clearly this was meant to *not* record the dependency in
that case.
50e17ad28 made this mistake first, then in v15 29f45e299 copied the same
mistake.
Reported-by: Tom Lane
Backpatch-through: 14, where 50e17ad28 first made this mistake
Discussion: https://postgr.es/m/2277537.1694301772@sss.pgh.pa.us
| -rw-r--r-- | src/backend/optimizer/plan/setrefs.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/optimizer/plan/setrefs.c b/src/backend/optimizer/plan/setrefs.c index 4830cd97a2c..182171d779b 100644 --- a/src/backend/optimizer/plan/setrefs.c +++ b/src/backend/optimizer/plan/setrefs.c @@ -1886,10 +1886,10 @@ fix_expr_common(PlannerInfo *root, Node *node) set_sa_opfuncid(saop); record_plan_function_dependency(root, saop->opfuncid); - if (!OidIsValid(saop->hashfuncid)) + if (OidIsValid(saop->hashfuncid)) record_plan_function_dependency(root, saop->hashfuncid); - if (!OidIsValid(saop->negfuncid)) + if (OidIsValid(saop->negfuncid)) record_plan_function_dependency(root, saop->negfuncid); } else if (IsA(node, Const)) |