diff options
| author | Robert Haas <rhaas@postgresql.org> | 2011-06-17 14:28:45 -0400 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2011-06-17 14:33:03 -0400 |
| commit | 199d449c076a8564a9e8b113818f71c43f59d4cd (patch) | |
| tree | de19f4abdab97c271fb9d25df21603c96cf14250 | |
| parent | 07bc6fe6687fbf2ac0fea5b09fe5a4932a725368 (diff) | |
| download | postgresql-199d449c076a8564a9e8b113818f71c43f59d4cd.tar.gz postgresql-199d449c076a8564a9e8b113818f71c43f59d4cd.zip | |
Add overflow checks to int4 and int8 versions of generate_series().
The previous code went into an infinite loop after overflow. In fact,
an overflow is not really an error; it just means that the current
value is the last one we need to return. So, just arrange to stop
immediately when overflow is detected.
Back-patch all the way.
| -rw-r--r-- | src/backend/utils/adt/int.c | 4 | ||||
| -rw-r--r-- | src/backend/utils/adt/int8.c | 4 |
2 files changed, 8 insertions, 0 deletions
diff --git a/src/backend/utils/adt/int.c b/src/backend/utils/adt/int.c index 47a0bd2a801..8bf3751cdc8 100644 --- a/src/backend/utils/adt/int.c +++ b/src/backend/utils/adt/int.c @@ -1470,6 +1470,10 @@ generate_series_step_int4(PG_FUNCTION_ARGS) /* increment current in preparation for next iteration */ fctx->current += fctx->step; + /* if next-value computation overflows, this is the final result */ + if (SAMESIGN(result, fctx->step) && !SAMESIGN(result, fctx->current)) + fctx->step = 0; + /* do when there is more left to send */ SRF_RETURN_NEXT(funcctx, Int32GetDatum(result)); } diff --git a/src/backend/utils/adt/int8.c b/src/backend/utils/adt/int8.c index 5901d407de1..876b2d97f1c 100644 --- a/src/backend/utils/adt/int8.c +++ b/src/backend/utils/adt/int8.c @@ -1268,6 +1268,10 @@ generate_series_step_int8(PG_FUNCTION_ARGS) /* increment current in preparation for next iteration */ fctx->current += fctx->step; + /* if next-value computation overflows, this is the final result */ + if (SAMESIGN(result, fctx->step) && !SAMESIGN(result, fctx->current)) + fctx->step = 0; + /* do when there is more left to send */ SRF_RETURN_NEXT(funcctx, Int64GetDatum(result)); } |