diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2018-08-07 16:00:44 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2018-08-07 16:00:55 -0400 |
| commit | 1b5438ec2a4ddb2bc632916efc1ec89f593dac06 (patch) | |
| tree | a1f72cfeb67403d875fa9b5f758ae7c3eb7e0f89 | |
| parent | 187331fefdb0b4cc2c2aaab42c754dcafa2a0f08 (diff) | |
| download | postgresql-1b5438ec2a4ddb2bc632916efc1ec89f593dac06.tar.gz postgresql-1b5438ec2a4ddb2bc632916efc1ec89f593dac06.zip | |
Fix incorrect initialization of BackendActivityBuffer.
Since commit c8e8b5a6e, this has been zeroed out using the wrong length.
In practice the length would always be too small, leading to not zeroing
the whole buffer rather than clobbering additional memory; and that's
pretty harmless, both because shmem would likely start out as zeroes
and because we'd reinitialize any given entry before use. Still,
it's bogus, so fix it.
Reported by Petru-Florin Mihancea (bug #15312)
Discussion: https://postgr.es/m/153363913073.1303.6518849192351268091@wrigleys.postgresql.org
| -rw-r--r-- | src/backend/postmaster/pgstat.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/postmaster/pgstat.c b/src/backend/postmaster/pgstat.c index 084573e77c0..10e7acce846 100644 --- a/src/backend/postmaster/pgstat.c +++ b/src/backend/postmaster/pgstat.c @@ -2695,7 +2695,7 @@ CreateSharedBackendStatus(void) if (!found) { - MemSet(BackendActivityBuffer, 0, size); + MemSet(BackendActivityBuffer, 0, BackendActivityBufferSize); /* Initialize st_activity pointers. */ buffer = BackendActivityBuffer; |