diff options
| author | Thomas Munro <tmunro@postgresql.org> | 2021-07-22 14:11:17 +1200 |
|---|---|---|
| committer | Thomas Munro <tmunro@postgresql.org> | 2021-07-22 15:07:52 +1200 |
| commit | 1cfc9f2ef61df81fa54a697081e372672c23e980 (patch) | |
| tree | 94d730cd4c731a5e03bb823f6163ac28c0c1bf1e | |
| parent | 8344979d5bbc63aa8fb8c804bd933c887a2abb58 (diff) | |
| download | postgresql-1cfc9f2ef61df81fa54a697081e372672c23e980.tar.gz postgresql-1cfc9f2ef61df81fa54a697081e372672c23e980.zip | |
jit: Don't inline functions that access thread-locals.
Code inlined by LLVM can crash or fail with "Relocation type not
implemented yet!" if it tries to access thread local variables. Don't
inline such code.
Back-patch to 11, where LLVM arrived. Bug #16696.
Author: Dmitry Marakasov <amdmi3@amdmi3.ru>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/16696-29d944a33801fbfe@postgresql.org
| -rw-r--r-- | src/backend/jit/llvm/llvmjit_inline.cpp | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/src/backend/jit/llvm/llvmjit_inline.cpp b/src/backend/jit/llvm/llvmjit_inline.cpp index 2617a461cad..40b18d9a0eb 100644 --- a/src/backend/jit/llvm/llvmjit_inline.cpp +++ b/src/backend/jit/llvm/llvmjit_inline.cpp @@ -609,6 +609,17 @@ function_inlinable(llvm::Function &F, elog(FATAL, "failed to materialize metadata"); /* + * Don't inline functions that access thread local variables. That + * doesn't work on current LLVM releases (but might in future). + */ + if (rv->isThreadLocal()) + { + ilog(DEBUG1, "cannot inline %s due to thread-local variable %s", + F.getName().data(), rv->getName().data()); + return false; + } + + /* * Never want to inline externally visible vars, cheap enough to * reference. */ |