aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2017-06-19 18:32:22 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2017-06-19 18:32:22 -0400
commit1dce0536497d12957c2c71498ca893672f1135c0 (patch)
treec405017540fa4f56407da89f71b79b864a4e20f3
parent1f184426b7637a64c1f43d3c70a3db3f9b949893 (diff)
downloadpostgresql-1dce0536497d12957c2c71498ca893672f1135c0.tar.gz
postgresql-1dce0536497d12957c2c71498ca893672f1135c0.zip
Fix materialized-view documentation oversights.
When materialized views were added, psql's \d commands were made to treat them as a separate object category ... but not everyplace in the documentation or comments got the memo. Noted by David Johnston. Back-patch to 9.3 where matviews came in. Discussion: https://postgr.es/m/CAKFQuwb27M3VXRhHErjCpkWwN9eKThbqWb1=trtoXi9_ejqPXQ@mail.gmail.com
-rw-r--r--doc/src/sgml/ref/psql-ref.sgml12
-rw-r--r--src/bin/psql/describe.c2
2 files changed, 8 insertions, 6 deletions
diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml
index 0c846e14522..d74d025bee8 100644
--- a/doc/src/sgml/ref/psql-ref.sgml
+++ b/doc/src/sgml/ref/psql-ref.sgml
@@ -1071,7 +1071,8 @@ testdb=&gt;
<listitem>
<para>
- For each relation (table, view, index, sequence, or foreign table)
+ For each relation (table, view, materialized view, index, sequence,
+ or foreign table)
or composite type matching the
<replaceable class="parameter">pattern</replaceable>, show all
columns, their types, the tablespace (if not the default) and any
@@ -1086,8 +1087,8 @@ testdb=&gt;
<para>
For some types of relation, <literal>\d</> shows additional information
- for each column: column values for sequences, indexed expression for
- indexes and foreign data wrapper options for foreign tables.
+ for each column: column values for sequences, indexed expressions for
+ indexes, and foreign data wrapper options for foreign tables.
</para>
<para>
@@ -1109,8 +1110,9 @@ testdb=&gt;
<para>
If <command>\d</command> is used without a
<replaceable class="parameter">pattern</replaceable> argument, it is
- equivalent to <command>\dtvsE</command> which will show a list of
- all visible tables, views, sequences and foreign tables.
+ equivalent to <command>\dtvmsE</command> which will show a list of
+ all visible tables, views, materialized views, sequences and
+ foreign tables.
This is purely a convenience measure.
</para>
</note>
diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c
index e48f347031c..6b1436cdbdf 100644
--- a/src/bin/psql/describe.c
+++ b/src/bin/psql/describe.c
@@ -2993,7 +2993,6 @@ listDbRoleSettings(const char *pattern, const char *pattern2)
* s - sequences
* E - foreign table (Note: different from 'f', the relkind value)
* (any order of the above is fine)
- * If tabtypes is empty, we default to \dtvsE.
*/
bool
listTables(const char *tabtypes, const char *pattern, bool verbose, bool showSystem)
@@ -3010,6 +3009,7 @@ listTables(const char *tabtypes, const char *pattern, bool verbose, bool showSys
printQueryOpt myopt = pset.popt;
static const bool translate_columns[] = {false, false, true, false, false, false, false};
+ /* If tabtypes is empty, we default to \dtvmsE (but see also command.c) */
if (!(showTables || showIndexes || showViews || showMatViews || showSeq || showForeign))
showTables = showViews = showMatViews = showSeq = showForeign = true;