diff options
| author | Andres Freund <andres@anarazel.de> | 2022-01-21 11:22:55 -0800 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2022-01-21 11:22:55 -0800 |
| commit | 1fabec7d7c389181424fa7881632a415584ca7b7 (patch) | |
| tree | 8508e6d4df8403ba37972f06fa72f5f719eca7e7 | |
| parent | 6c07f9ebce1579612c4ed9076159f9e942e50f9d (diff) | |
| download | postgresql-1fabec7d7c389181424fa7881632a415584ca7b7.tar.gz postgresql-1fabec7d7c389181424fa7881632a415584ca7b7.zip | |
fsync pg_logical/mappings in CheckPointLogicalRewriteHeap().
While individual logical rewrite files were synced to disk, the directory was
not. On some filesystems that could lead to loosing directory entries after a
crash.
Reported-By: Tom Lane <tgl@sss.pgh.pa.us>
Author: Nathan Bossart <bossartn@amazon.com>
Discussion: https://postgr.es/m/867F2E29-2782-4869-970E-B984C6D35A8F@amazon.com
Backpatch: 10-
| -rw-r--r-- | src/backend/access/heap/rewriteheap.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/backend/access/heap/rewriteheap.c b/src/backend/access/heap/rewriteheap.c index aa265edf601..2a53826736e 100644 --- a/src/backend/access/heap/rewriteheap.c +++ b/src/backend/access/heap/rewriteheap.c @@ -1282,4 +1282,7 @@ CheckPointLogicalRewriteHeap(void) } } FreeDir(mappings_dir); + + /* persist directory entries to disk */ + fsync_fname("pg_logical/mappings", true); } |