aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNoah Misch <noah@leadboat.com>2019-04-14 00:36:47 -0700
committerNoah Misch <noah@leadboat.com>2019-04-14 00:36:47 -0700
commit2bc0474792e346c6c7f16cdc33607568e9e92c74 (patch)
tree105a79bccec85779e9d8277a235661d35d84c30c
parent61c0962d90d5386a24a30970ff4635cce68051bb (diff)
downloadpostgresql-2bc0474792e346c6c7f16cdc33607568e9e92c74.tar.gz
postgresql-2bc0474792e346c6c7f16cdc33607568e9e92c74.zip
MSYS: Skip src/test/recovery/t/017_shm.pl.
Commit 947a35014fdc2ec74cbf06c7dbac6eea6fae90c6 relied on a feature available in v11 and later, so back-patching it to v10 and v9.6 was invalid. In those branches, revert it and skip the test on msys. Discussion: https://postgr.es/m/GrdLgAdUK9FdyZg8VIcTDKVOkys122ZINEb3CjjoySfGj2KyPiMKTh1zqtRp0TAD7FJ27G-OBB3eplxIB5GhcQH5o8zzGZfp0MuJaXJxVxk=@yesql.se
-rw-r--r--src/test/perl/PostgresNode.pm4
-rw-r--r--src/test/recovery/t/017_shm.pl9
2 files changed, 9 insertions, 4 deletions
diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm
index fff8c992a37..52708205850 100644
--- a/src/test/perl/PostgresNode.pm
+++ b/src/test/perl/PostgresNode.pm
@@ -734,9 +734,7 @@ sub kill9
my $name = $self->name;
return unless defined $self->{_pid};
print "### Killing node \"$name\" using signal 9\n";
- # kill(9, ...) fails under msys Perl 5.8.8, so fall back on pg_ctl.
- kill(9, $self->{_pid})
- or TestLib::system_or_bail('pg_ctl', 'kill', 'KILL', $self->{_pid});
+ kill(9, $self->{_pid}) or BAIL_OUT("kill(9, $self->{_pid}) failed");
$self->{_pid} = undef;
return;
}
diff --git a/src/test/recovery/t/017_shm.pl b/src/test/recovery/t/017_shm.pl
index 3cbe938ddd1..633606b2be0 100644
--- a/src/test/recovery/t/017_shm.pl
+++ b/src/test/recovery/t/017_shm.pl
@@ -9,7 +9,14 @@ use Test::More;
use TestLib;
use Time::HiRes qw(usleep);
-plan tests => 5;
+if ($^O eq 'msys')
+{
+ plan skip_all => 'missing SIGKILL implementation';
+}
+else
+{
+ plan tests => 5;
+}
my $tempdir = TestLib::tempdir;
my $port;