diff options
| author | Michael Paquier <michael@paquier.xyz> | 2023-01-19 13:13:28 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2023-01-19 13:13:28 +0900 |
| commit | 2e21e2857e5657b6867b337ddce5a22afce320c6 (patch) | |
| tree | 93ac7b653cde8e340b08f5906c093e5d280e8483 | |
| parent | efd2474ab5b40778722054659e52254840773f95 (diff) | |
| download | postgresql-2e21e2857e5657b6867b337ddce5a22afce320c6.tar.gz postgresql-2e21e2857e5657b6867b337ddce5a22afce320c6.zip | |
Add missing assign hook for GUC checkpoint_completion_target
This is wrong since 88e9823, that has switched the WAL sizing
configuration from checkpoint_segments to min_wal_size and
max_wal_size. This missed the recalculation of the internal value of
the internal "CheckPointSegments", that works as a mapping of the old
GUC checkpoint_segments, on reload, for example, and it controls the
timing of checkpoints depending on the volume of WAL generated.
Most users tend to leave checkpoint_completion_target at 0.9 to smooth
the I/O workload, which is why I guess this has gone unnoticed for so
long, still it can be useful to tweak and reload the value dynamically
in some cases to control the timing of checkpoints.
Author: Bharath Rupireddy
Discussion: https://postgr.es/m/CALj2ACXgPPAm28mruojSBno+F_=9cTOOxHAywu_dfZPeBdybQw@mail.gmail.com
Backpatch-through: 11
| -rw-r--r-- | src/backend/utils/misc/guc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index ef62bb81885..ab6e9437432 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -3798,7 +3798,7 @@ static struct config_real ConfigureNamesReal[] = }, &CheckPointCompletionTarget, 0.9, 0.0, 1.0, - NULL, NULL, NULL + NULL, assign_checkpoint_completion_target, NULL }, { |