aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorÁlvaro Herrera <alvherre@alvh.no-ip.org>2024-11-21 17:04:26 +0100
committerÁlvaro Herrera <alvherre@alvh.no-ip.org>2024-11-21 17:07:02 +0100
commit2fb3919356fb94dfef37998bf0439cc6896c93d4 (patch)
tree1827623c9740a3afb09375dea29bd0c6ad11697c
parente2b08a6295826a0dd8ee905e9f8d2c8940fca049 (diff)
downloadpostgresql-2fb3919356fb94dfef37998bf0439cc6896c93d4.tar.gz
postgresql-2fb3919356fb94dfef37998bf0439cc6896c93d4.zip
Fix newly introduced 010_keep_recycled_wals.pl
It failed to set the archive_command as it desired because of a syntax problem. Oversight in commit 90bcc7c2db1d. This bug doesn't cause the test to fail, because the test only checks pg_rewind's output messages, not the actual outcome (and the outcome in both cases is that the file is kept, not deleted). But in either case the message about the file being kept is there, so it's hard to get excited about doing much more. Reported-by: Antonin Houska <ah@cybertec.at> Author: Alexander Kukushkin <cyberdemn@gmail.com> Discussion: https://postgr.es/m/7822.1732167825@antos
-rw-r--r--src/bin/pg_rewind/t/010_keep_recycled_wals.pl4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/bin/pg_rewind/t/010_keep_recycled_wals.pl b/src/bin/pg_rewind/t/010_keep_recycled_wals.pl
index e6dfce2a54a..bf0084d3bc3 100644
--- a/src/bin/pg_rewind/t/010_keep_recycled_wals.pl
+++ b/src/bin/pg_rewind/t/010_keep_recycled_wals.pl
@@ -23,9 +23,9 @@ $node_standby->reload();
RewindTest::primary_psql("CHECKPOINT"); # last common checkpoint
-# We use "perl -e 'exit(1)'" as an alternative to "false", because the latter
+# We use `perl -e "exit(1)"` as an alternative to "false", because the latter
# might not be available on Windows.
-my $false = "$^X -e 'exit(1)'";
+my $false = "$^X -e \"exit(1)\"";
$node_primary->append_conf(
'postgresql.conf', qq(
archive_command = '$false'