diff options
| author | Peter Eisentraut <peter_e@gmx.net> | 2012-03-08 22:29:01 +0200 |
|---|---|---|
| committer | Peter Eisentraut <peter_e@gmx.net> | 2012-03-11 01:03:09 +0200 |
| commit | 3043608cf72b0abd8b022034080f44cc29ff0cf5 (patch) | |
| tree | 16c89b24d1806e772188a494a45d200a997a6c36 | |
| parent | 6f59d42b943e721c6ddf9513e3e82067ca40bce5 (diff) | |
| download | postgresql-3043608cf72b0abd8b022034080f44cc29ff0cf5.tar.gz postgresql-3043608cf72b0abd8b022034080f44cc29ff0cf5.zip | |
ecpg: Fix off-by-one error in memory copying
In a rare case, one byte past the end of memory belonging to the
sqlca_t structure would be written to.
found by Coverity
| -rw-r--r-- | src/interfaces/ecpg/ecpglib/misc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/interfaces/ecpg/ecpglib/misc.c b/src/interfaces/ecpg/ecpglib/misc.c index 98e0597b03c..c29f933ef9c 100644 --- a/src/interfaces/ecpg/ecpglib/misc.c +++ b/src/interfaces/ecpg/ecpglib/misc.c @@ -530,7 +530,7 @@ ECPGset_var(int number, void *pointer, int lineno) struct sqlca_t *sqlca = ECPGget_sqlca(); sqlca->sqlcode = ECPG_OUT_OF_MEMORY; - strncpy(sqlca->sqlstate, "YE001", sizeof("YE001")); + strncpy(sqlca->sqlstate, "YE001", sizeof(sqlca->sqlstate)); snprintf(sqlca->sqlerrm.sqlerrmc, sizeof(sqlca->sqlerrm.sqlerrmc), "out of memory on line %d", lineno); sqlca->sqlerrm.sqlerrml = strlen(sqlca->sqlerrm.sqlerrmc); /* free all memory we have allocated for the user */ |