diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2005-10-03 23:43:45 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2005-10-03 23:43:45 +0000 |
| commit | 31d276d0ed6d26f633a6348c8f9602bfb660650e (patch) | |
| tree | c466b32c695da4fbeb6a7579050d4b7b96a2cc76 | |
| parent | 4082f5e34f20872ab150b5707bc6d662cbe9b757 (diff) | |
| download | postgresql-31d276d0ed6d26f633a6348c8f9602bfb660650e.tar.gz postgresql-31d276d0ed6d26f633a6348c8f9602bfb660650e.zip | |
COPY's test for read-only transaction was backward; it prohibited COPY TOREL7_4_9
where it should prohibit COPY FROM. Found by Alon Goldshuv.
| -rw-r--r-- | doc/src/sgml/release.sgml | 7 | ||||
| -rw-r--r-- | src/backend/commands/copy.c | 5 |
2 files changed, 9 insertions, 3 deletions
diff --git a/doc/src/sgml/release.sgml b/doc/src/sgml/release.sgml index e593e47af56..7888e465c27 100644 --- a/doc/src/sgml/release.sgml +++ b/doc/src/sgml/release.sgml @@ -1,5 +1,5 @@ <!-- -$Header: /cvsroot/pgsql/doc/src/sgml/release.sgml,v 1.235.2.32 2005/10/03 16:05:09 tgl Exp $ +$Header: /cvsroot/pgsql/doc/src/sgml/release.sgml,v 1.235.2.33 2005/10/03 23:43:42 tgl Exp $ --> <appendix id="release"> @@ -41,6 +41,11 @@ length when using a multiple-byte character set (Yoshiyuki Asaba)</para> <para>In prior releases, the padding of <type>CHAR()</> was incorrect because it only padded to the specified number of bytes without considering how many characters were stored.</para></listitem> +<listitem><para>Fix the sense of the test for read-only transaction +in <command>COPY</></para> +<para>The code formerly prohibited <command>COPY TO</>, where it should +prohibit <command>COPY FROM</>. +</para></listitem> <listitem><para>Fix planning problem with outer-join ON clauses that reference only the inner-side relation</para></listitem> <listitem><para>Further fixes for <literal>x FULL JOIN y ON true</> corner diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c index 95f860200c0..c4e261549a2 100644 --- a/src/backend/commands/copy.c +++ b/src/backend/commands/copy.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/commands/copy.c,v 1.213.2.1 2004/01/18 02:15:57 tgl Exp $ + * $Header: /cvsroot/pgsql/src/backend/commands/copy.c,v 1.213.2.2 2005/10/03 23:43:45 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -752,7 +752,8 @@ DoCopy(const CopyStmt *stmt) rel = heap_openrv(relation, (is_from ? RowExclusiveLock : AccessShareLock)); /* check read-only transaction */ - if (XactReadOnly && !is_from && !isTempNamespace(RelationGetNamespace(rel))) + if (XactReadOnly && is_from && + !isTempNamespace(RelationGetNamespace(rel))) ereport(ERROR, (errcode(ERRCODE_READ_ONLY_SQL_TRANSACTION), errmsg("transaction is read-only"))); |