diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2024-04-01 19:01:18 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2024-04-01 19:01:18 -0400 |
| commit | 3235a11c128b5979bce84d56b8044c7fb2e6b61d (patch) | |
| tree | 1cbd07702c6c592d825fad83e875a3292ff9ccdd | |
| parent | 14e4e8f8c66b2d4316ecb1276e688d67c25659c2 (diff) | |
| download | postgresql-3235a11c128b5979bce84d56b8044c7fb2e6b61d.tar.gz postgresql-3235a11c128b5979bce84d56b8044c7fb2e6b61d.zip | |
Avoid "unused variable" warning on non-USE_SSL_ENGINE platforms.
If we are building with openssl but USE_SSL_ENGINE didn't get set,
initialize_SSL's variable "pkey" is declared but used nowhere.
Apparently this combination hasn't been exercised in the buildfarm
before now, because I've not seen this warning before, even though
the code has been like this a long time. Move the declaration
to silence the warning (and remove its useless initialization).
Per buildfarm member sawshark. Back-patch to all supported branches.
| -rw-r--r-- | src/interfaces/libpq/fe-secure-openssl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/interfaces/libpq/fe-secure-openssl.c b/src/interfaces/libpq/fe-secure-openssl.c index c2858096b5d..a44d7d3f29e 100644 --- a/src/interfaces/libpq/fe-secure-openssl.c +++ b/src/interfaces/libpq/fe-secure-openssl.c @@ -915,7 +915,6 @@ initialize_SSL(PGconn *conn) bool have_homedir; bool have_cert; bool have_rootcert; - EVP_PKEY *pkey = NULL; /* * We'll need the home directory if any of the relevant parameters are @@ -1265,6 +1264,7 @@ initialize_SSL(PGconn *conn) /* Colon, but not in second character, treat as engine:key */ char *engine_str = strdup(conn->sslkey); char *engine_colon; + EVP_PKEY *pkey; if (engine_str == NULL) { |