diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2008-08-20 15:49:30 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2008-08-20 15:49:30 +0000 |
| commit | 390e59cd5f124e9b0d0163a47ce4771f4d287628 (patch) | |
| tree | b7e9cd985ebbaaf7b159dc0b736077c0d69e11da | |
| parent | 0ba9b565b95eae16f5d10ff71903d7495a802d92 (diff) | |
| download | postgresql-390e59cd5f124e9b0d0163a47ce4771f4d287628.tar.gz postgresql-390e59cd5f124e9b0d0163a47ce4771f4d287628.zip | |
Fix obsolete comment. It's no longer the case that Param nodes don't
carry typmod.
| -rw-r--r-- | src/backend/optimizer/plan/subselect.c | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/src/backend/optimizer/plan/subselect.c b/src/backend/optimizer/plan/subselect.c index 9eaeaedc68f..37194eb5c4d 100644 --- a/src/backend/optimizer/plan/subselect.c +++ b/src/backend/optimizer/plan/subselect.c @@ -7,7 +7,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/optimizer/plan/subselect.c,v 1.135 2008/08/17 02:19:19 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/optimizer/plan/subselect.c,v 1.136 2008/08/20 15:49:30 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -94,14 +94,9 @@ replace_outer_var(PlannerInfo *root, Var *var) * NOTE: in sufficiently complex querytrees, it is possible for the same * varno/abslevel to refer to different RTEs in different parts of the * parsetree, so that different fields might end up sharing the same Param - * number. As long as we check the vartype as well, I believe that this - * sort of aliasing will cause no trouble. The correct field should get - * stored into the Param slot at execution in each part of the tree. - * - * We also need to demand a match on vartypmod. This does not matter for - * the Param itself, since those are not typmod-dependent, but it does - * matter when make_subplan() instantiates a modified copy of the Var for - * a subplan's args list. + * number. As long as we check the vartype/typmod as well, I believe that + * this sort of aliasing will cause no trouble. The correct field should + * get stored into the Param slot at execution in each part of the tree. */ i = 0; foreach(ppl, root->glob->paramlist) |