diff options
| author | Robert Haas <rhaas@postgresql.org> | 2015-08-04 12:58:54 -0400 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2015-08-04 13:05:48 -0400 |
| commit | 3a35ca5add65fb58bda52d62695a5b83cd6c0ae7 (patch) | |
| tree | a7e39e8760118b3c005c9dac4e05928a58e2c942 | |
| parent | 4424356c033d4f10f7f0d18f2835f219ee09c8c0 (diff) | |
| download | postgresql-3a35ca5add65fb58bda52d62695a5b83cd6c0ae7.tar.gz postgresql-3a35ca5add65fb58bda52d62695a5b83cd6c0ae7.zip | |
Cap wal_buffers to avoid a server crash when it's set very large.
It must be possible to multiply wal_buffers by XLOG_BLCKSZ without
overflowing int, or calculations in StartupXLOG will go badly wrong
and crash the server. Avoid that by imposing a maximum value on
wal_buffers. This will be just under 2GB, assuming the usual value
for XLOG_BLCKSZ.
Josh Berkus, per an analysis by Andrew Gierth.
| -rw-r--r-- | src/backend/utils/misc/guc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 396c68b30ef..3baf4c16ffa 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -2096,7 +2096,7 @@ static struct config_int ConfigureNamesInt[] = GUC_UNIT_XBLOCKS }, &XLOGbuffers, - -1, -1, INT_MAX, + -1, -1, (INT_MAX / XLOG_BLCKSZ), check_wal_buffers, NULL, NULL }, |