aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTomas Vondra <tomas.vondra@postgresql.org>2022-03-27 00:11:38 +0100
committerTomas Vondra <tomas.vondra@postgresql.org>2022-03-27 00:11:38 +0100
commit404f49338fef32150f930ddfa8ae0411b5e35121 (patch)
tree9d48da699abd5cb2fb1ca1c4d11ccd9f572d0510
parent4a7e964fc67a541b6ea1b72729ad3f8e632d003c (diff)
downloadpostgresql-404f49338fef32150f930ddfa8ae0411b5e35121.tar.gz
postgresql-404f49338fef32150f930ddfa8ae0411b5e35121.zip
Wait for subscription to sync in t/031_column_list.sql
One of the TAP tests added in 923def9a53 did not wait after creating a subscription, and wait_for_catchup is not sufficient for this. So if the tablesync workers happen do not complete quickly enough, the test won't see the expected results. This probably explains intermittent failures on a couple buildfarm animals (komodoensis, petalura and snapper). Reported-by: Tom Lane Discussion: https://postgr.es/m/170549.1648330634@sss.pgh.pa.us
-rw-r--r--src/test/subscription/t/031_column_list.pl2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test/subscription/t/031_column_list.pl b/src/test/subscription/t/031_column_list.pl
index c778840f4c1..bdcf3e4a248 100644
--- a/src/test/subscription/t/031_column_list.pl
+++ b/src/test/subscription/t/031_column_list.pl
@@ -722,7 +722,7 @@ $node_subscriber->safe_psql('postgres', qq(
CREATE SUBSCRIPTION sub1 CONNECTION '$publisher_connstr' PUBLICATION pub8;
));
-$node_publisher->wait_for_catchup('sub1');
+wait_for_subscription_sync($node_subscriber);
$node_publisher->safe_psql('postgres', qq(
INSERT INTO test_part_c VALUES (3, 7, 8);