diff options
| author | Robert Haas <rhaas@postgresql.org> | 2017-09-29 13:51:14 -0400 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2017-09-29 13:56:04 -0400 |
| commit | 434146d21666dd2023705fb26582918212e124d1 (patch) | |
| tree | d7b9890534d80533753f2bac680b43ee4a555343 | |
| parent | 5cc5987cedd8c60c738135abcb25df5247db7d1e (diff) | |
| download | postgresql-434146d21666dd2023705fb26582918212e124d1.tar.gz postgresql-434146d21666dd2023705fb26582918212e124d1.zip | |
pgbench: If we fail to send a command to the server, fail.
This beats the old behavior of busy-waiting hands down.
Oversight in commit 12788ae49e1933f463bc59a6efe46c4a01701b76.
Report by Pavan Deolasee. Patch by Fabien Coelho. Reviewed by
Pavan Deolasee.
Discussion: http://postgr.es/m/CABOikdPhfXTypckMC1Ux6Ko+hKBWwUBA=EXsvamXYSg8M9J94w@mail.gmail.com
| -rw-r--r-- | src/bin/pgbench/pgbench.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c index ae78c7b1d46..58fdc477eee 100644 --- a/src/bin/pgbench/pgbench.c +++ b/src/bin/pgbench/pgbench.c @@ -2157,12 +2157,8 @@ doCustom(TState *thread, CState *st, StatsData *agg) { if (!sendCommand(st, command)) { - /* - * Failed. Stay in CSTATE_START_COMMAND state, to - * retry. ??? What the point or retrying? Should - * rather abort? - */ - return; + commandFailed(st, "SQL command send failed"); + st->state = CSTATE_ABORTED; } else st->state = CSTATE_WAIT_RESULT; |