diff options
| author | Robert Haas <rhaas@postgresql.org> | 2023-03-28 16:16:53 -0400 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2023-03-28 16:17:03 -0400 |
| commit | 453f53821fa549d3e46c87a076fc7849fab9a948 (patch) | |
| tree | 1f0a6bc573e07d7afe950447f519be53fe259614 | |
| parent | bf5c4b3d9da67ab0dd8a5a560804f88370c42866 (diff) | |
| download | postgresql-453f53821fa549d3e46c87a076fc7849fab9a948.tar.gz postgresql-453f53821fa549d3e46c87a076fc7849fab9a948.zip | |
amcheck: In verify_heapam, allows tuples with xmin 0.
Commit e88754a1965c0f40a723e6e46d670cacda9e19bd caused that case
to be reported as corruption, but Peter Geoghegan pointed out that
it can legitimately happen in the case of a speculative insertion
that aborts, so we'd better not flag it as corruption after all.
Back-patch to v14, like the commit that introduced the issue.
Discussion: http://postgr.es/m/CAH2-WzmEabzcPTxSY-NXKH6Qt3FkAPYHGQSe2PtvGgj17ZQkCw@mail.gmail.com
| -rw-r--r-- | contrib/amcheck/verify_heapam.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/contrib/amcheck/verify_heapam.c b/contrib/amcheck/verify_heapam.c index 1d186d1e4de..4e3e87aa800 100644 --- a/contrib/amcheck/verify_heapam.c +++ b/contrib/amcheck/verify_heapam.c @@ -739,8 +739,7 @@ check_tuple_visibility(HeapCheckContext *ctx) switch (get_xid_status(xmin, ctx, &xmin_status)) { case XID_INVALID: - report_corruption(ctx, - pstrdup("xmin is invalid")); + /* Could be the result of a speculative insertion that aborted. */ return false; case XID_BOUNDS_OK: break; |