diff options
| author | Noah Misch <noah@leadboat.com> | 2024-02-19 12:52:07 -0800 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2024-02-19 12:52:07 -0800 |
| commit | 4791f87f34bd3a055db34519d6f878afeedd2548 (patch) | |
| tree | 74525935c52beee30419929664e9eb631f302802 | |
| parent | 7f2718532401cfcf5ad2d5d6e7feb15a91b6aa03 (diff) | |
| download | postgresql-4791f87f34bd3a055db34519d6f878afeedd2548.tar.gz postgresql-4791f87f34bd3a055db34519d6f878afeedd2548.zip | |
Bound waits in 035_standby_logical_decoding.pl.
One IPC::Run::start() used an IPC::Run::timer() without checking for
expiration. The other used no timeout or timer. Back-patch to v16,
which introduced the test.
Reviewed by Bertrand Drouvot.
Discussion: https://postgr.es/m/20240211010227.a2.nmisch@google.com
| -rw-r--r-- | src/test/recovery/t/035_standby_logical_decoding.pl | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/test/recovery/t/035_standby_logical_decoding.pl b/src/test/recovery/t/035_standby_logical_decoding.pl index cebfa52d0fc..b020361b297 100644 --- a/src/test/recovery/t/035_standby_logical_decoding.pl +++ b/src/test/recovery/t/035_standby_logical_decoding.pl @@ -21,7 +21,6 @@ my $node_cascading_standby = PostgreSQL::Test::Cluster->new('cascading_standby'); my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber'); my $default_timeout = $PostgreSQL::Test::Utils::timeout_default; -my $psql_timeout = IPC::Run::timer($default_timeout); my $res; # Name for the physical slot on primary @@ -90,7 +89,8 @@ sub make_slot_active '>', $to_stdout, '2>', - $to_stderr); + $to_stderr, + IPC::Run::timeout($default_timeout)); if ($wait) { @@ -341,7 +341,7 @@ $psql_subscriber{run} = IPC::Run::start( \$psql_subscriber{subscriber_stdout}, '2>', \$psql_subscriber{subscriber_stderr}, - $psql_timeout); + IPC::Run::timeout($default_timeout)); ################################################## # Test that logical decoding on the standby |