aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMagnus Hagander <magnus@hagander.net>2012-06-11 15:07:55 +0200
committerMagnus Hagander <magnus@hagander.net>2012-06-11 15:17:52 +0200
commit580b94168e2218a2a32d6792139d51c63104b2c2 (patch)
tree14f27cba304ff027723d6b52c6c8dcb68612ba54
parent557433f48ad1e55ce753282f4dfb8ef3606cda8d (diff)
downloadpostgresql-580b94168e2218a2a32d6792139d51c63104b2c2.tar.gz
postgresql-580b94168e2218a2a32d6792139d51c63104b2c2.zip
Prevent non-streaming replication connections from being selected sync slave
This prevents a pg_basebackup backup session that just does a base backup (no xlog involved at all) from becoming the synchronous slave and thus blocking all access while it runs. Also fixes the problem when a higher priority slave shows up it would become the sync standby before it has reached the STREAMING state, by making sure we can only switch to a walsender that's actually STREAMING. Fujii Masao
-rw-r--r--src/backend/replication/syncrep.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/backend/replication/syncrep.c b/src/backend/replication/syncrep.c
index 6463420cd85..d475e0383d4 100644
--- a/src/backend/replication/syncrep.c
+++ b/src/backend/replication/syncrep.c
@@ -399,6 +399,7 @@ SyncRepReleaseWaiters(void)
volatile WalSnd *walsnd = &walsndctl->walsnds[i];
if (walsnd->pid != 0 &&
+ walsnd->state == WALSNDSTATE_STREAMING &&
walsnd->sync_standby_priority > 0 &&
(priority == 0 ||
priority > walsnd->sync_standby_priority))