diff options
| author | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2016-12-16 12:50:20 +0200 |
|---|---|---|
| committer | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2016-12-16 12:53:12 +0200 |
| commit | 595333ff493a3b17d82133a01cd64128bb6175b7 (patch) | |
| tree | 27f6152a131686b2a03f695a86b6e2bd9634dfca | |
| parent | 492fe48f0113600e86449e3738a17d029dcfe144 (diff) | |
| download | postgresql-595333ff493a3b17d82133a01cd64128bb6175b7.tar.gz postgresql-595333ff493a3b17d82133a01cd64128bb6175b7.zip | |
Fix off-by-one in memory allocation for quote_literal_cstr().
The calculation didn't take into account the NULL terminator. That lead
to overwriting the palloc'd buffer by one byte, if the input consists
entirely of backslashes. For example "format('%L', E'\\')".
Fixes bug #14468. Backpatch to all supported versions.
Report: https://www.postgresql.org/message-id/20161216105001.13334.42819%40wrigleys.postgresql.org
| -rw-r--r-- | src/backend/utils/adt/quote.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/utils/adt/quote.c b/src/backend/utils/adt/quote.c index 761633bd459..7e502aed1e3 100644 --- a/src/backend/utils/adt/quote.c +++ b/src/backend/utils/adt/quote.c @@ -107,7 +107,7 @@ quote_literal_cstr(const char *rawstr) len = strlen(rawstr); /* We make a worst-case result area; wasting a little space is OK */ - result = palloc(len * 2 + 3); + result = palloc(len * 2 + 3 + 1); newlen = quote_literal_internal(result, rawstr, len); result[newlen] = '\0'; |