aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNoah Misch <noah@leadboat.com>2020-05-13 20:42:09 -0700
committerNoah Misch <noah@leadboat.com>2020-05-13 20:42:49 -0700
commit595b4115c91fb7cd217d2ed4460a397673baeaac (patch)
treecb7dbaf074b58122ce22f6aba38aaeeeed386e8a
parent7aa52945de3206191f8b2b121568d316ac4b234e (diff)
downloadpostgresql-595b4115c91fb7cd217d2ed4460a397673baeaac.tar.gz
postgresql-595b4115c91fb7cd217d2ed4460a397673baeaac.zip
Fix pg_recvlogical avoidance of superfluous Standby Status Update.
The defect suppressed a Standby Status Update message when bytes flushed to disk had changed but bytes received had not changed. If pg_recvlogical then exited with no intervening Standby Status Update, the next pg_recvlogical repeated already-flushed records. The defect could also cause superfluous messages, which are functionally harmless. Back-patch to 9.5 (all supported versions). Discussion: https://postgr.es/m/20200502221647.GA3941274@rfd.leadboat.com
-rw-r--r--src/bin/pg_basebackup/pg_recvlogical.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/bin/pg_basebackup/pg_recvlogical.c b/src/bin/pg_basebackup/pg_recvlogical.c
index 5907d607b09..7101f5fd515 100644
--- a/src/bin/pg_basebackup/pg_recvlogical.c
+++ b/src/bin/pg_basebackup/pg_recvlogical.c
@@ -121,7 +121,7 @@ sendFeedback(PGconn *conn, int64 now, bool force, bool replyRequested)
*/
if (!force &&
last_written_lsn == output_written_lsn &&
- last_fsync_lsn != output_fsync_lsn)
+ last_fsync_lsn == output_fsync_lsn)
return true;
if (verbose)