aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Paquier <michael@paquier.xyz>2020-01-15 13:58:46 +0900
committerMichael Paquier <michael@paquier.xyz>2020-01-15 13:58:46 +0900
commit5ec7bd819c5081d46a7e3bde60dcf7c01d7b8af9 (patch)
treed6bf00e6724285e403d14af260e4a161cdf7e3dc
parent749f702d13de750b0adaf0aedbcc3c01f078c0c2 (diff)
downloadpostgresql-5ec7bd819c5081d46a7e3bde60dcf7c01d7b8af9.tar.gz
postgresql-5ec7bd819c5081d46a7e3bde60dcf7c01d7b8af9.zip
Fix buggy logic in isTempNamespaceInUse()
The logic introduced in this routine as of 246a6c8 would report an incorrect result when a session calls it to check if the temporary namespace owned by the session is in use or not. It is possible to optimize more the routine in this case to avoid a PGPROC lookup, but let's keep the logic simple. As this routine is used only by autovacuum for now, there were no live bugs, still let's be correct for any future code involving it. Author: Michael Paquier Reviewed-by: Julien Rouhaud Discussion: https://postgr.es/m/20200113093703.GA41902@paquier.xyz Backpatch-through: 11
-rw-r--r--src/backend/catalog/namespace.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/catalog/namespace.c b/src/backend/catalog/namespace.c
index ed38350d7ce..5f68cc13776 100644
--- a/src/backend/catalog/namespace.c
+++ b/src/backend/catalog/namespace.c
@@ -3233,8 +3233,8 @@ isTempNamespaceInUse(Oid namespaceId)
backendId = GetTempNamespaceBackendId(namespaceId);
- if (backendId == InvalidBackendId ||
- backendId == MyBackendId)
+ /* No such temporary namespace? */
+ if (backendId == InvalidBackendId)
return false;
/* Is the backend alive? */