diff options
| author | Fujii Masao <fujii@postgresql.org> | 2024-07-09 21:03:56 +0900 |
|---|---|---|
| committer | Fujii Masao <fujii@postgresql.org> | 2024-07-09 21:30:18 +0900 |
| commit | 629520be5f9da9d0192c7f6c8796bfddb4746760 (patch) | |
| tree | 0ffbd614ba11acaad38e8a995038d0ac2af84ee3 | |
| parent | ca481d3c9ab7bf69ff0c8d71ad3951d407f6a33c (diff) | |
| download | postgresql-629520be5f9da9d0192c7f6c8796bfddb4746760.tar.gz postgresql-629520be5f9da9d0192c7f6c8796bfddb4746760.zip | |
Fix comment in libpqrcv_check_conninfo().
Previously, the comment incorrectly stated that libpqrcv_check_conninfo()
returns true or false based on the connection string check.
However, this function actually has a void return type and
raises an error if the check fails.
Author: Rintaro Ikeda
Reviewed-by: Jelte Fennema-Nio, Fujii Masao
Discussion: https://postgr.es/m/6a1ca81b27fec4da0ccdfaaaec787982@oss.nttdata.com
| -rw-r--r-- | src/backend/replication/libpqwalreceiver/libpqwalreceiver.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c index 02f12f29219..6c42c209d29 100644 --- a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c +++ b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c @@ -305,12 +305,12 @@ bad_connection: } /* - * Validate connection info string, and determine whether it might cause - * local filesystem access to be attempted. + * Validate connection info string. * * If the connection string can't be parsed, this function will raise - * an error and will not return. If it can, it will return true if this - * connection string specifies a password and false otherwise. + * an error. If must_use_password is true, the function raises an error + * if no password is provided in the connection string. In any other case + * it successfully completes. */ static void libpqrcv_check_conninfo(const char *conninfo, bool must_use_password) |