diff options
| author | Peter Eisentraut <peter@eisentraut.org> | 2023-05-05 06:29:49 +0200 |
|---|---|---|
| committer | Peter Eisentraut <peter@eisentraut.org> | 2023-05-05 07:11:58 +0200 |
| commit | 6704944779cfbc420fdefc6992ccb6a048ddc4a5 (patch) | |
| tree | c3f86395793e3d2b70e9eb1f25339356f4ea6d54 | |
| parent | 800531846ef7da5f4a234fbb6fd65a91c7ecb33f (diff) | |
| download | postgresql-6704944779cfbc420fdefc6992ccb6a048ddc4a5.tar.gz postgresql-6704944779cfbc420fdefc6992ccb6a048ddc4a5.zip | |
Fix prove_installcheck when used with PGXS
Commit 153e215677 added the portlock directory. This is created in
$ENV{top_builddir} if it is set. Under PGXS, top_builddir points into
the installation directory, which is not necessarily writable and in
any case inappropriate to use by a test suite. The cause of the
problem is that the prove_installcheck target in Makefile.global
exports top_builddir, which isn't useful (since no other Perl code
actually reads it) and breaks this use case. The reason this code is
there is probably that is has been dragged around with various other
changes, in particular a0fc813266, but without a real purpose of its
own. By just removing the exporting of top_builddir in
prove_installcheck, the portlock directory then ends up under
tmp_check in the build directory, which is more suitable.
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://www.postgresql.org/message-id/78d1cfa6-0065-865d-584b-cde6d8c18aff@enterprisedb.com
| -rw-r--r-- | src/Makefile.global.in | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/Makefile.global.in b/src/Makefile.global.in index fa3bf734e61..1a4097d75c8 100644 --- a/src/Makefile.global.in +++ b/src/Makefile.global.in @@ -460,7 +460,6 @@ rm -rf '$(CURDIR)'/tmp_check $(MKDIR_P) '$(CURDIR)'/tmp_check cd $(srcdir) && \ TESTDIR='$(CURDIR)' PATH="$(bindir):$$PATH" PGPORT='6$(DEF_PGPORT)' \ - top_builddir='$(top_builddir)' \ PG_REGRESS='$(top_builddir)/src/test/regress/pg_regress' \ $(PROVE) $(PG_PROVE_FLAGS) $(PROVE_FLAGS) $(if $(PROVE_TESTS),$(PROVE_TESTS),t/*.pl) endef |