diff options
| author | Michael Paquier <michael@paquier.xyz> | 2021-07-29 10:59:56 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2021-07-29 10:59:56 +0900 |
| commit | 67445deb7eca32d25721dffb228b009bfbe415d5 (patch) | |
| tree | 54394800f4a719c9a84238e70ad25ccc62524e88 | |
| parent | f2a3d7404e5d4aa17dbdf7299b1f0d548fe59b9d (diff) | |
| download | postgresql-67445deb7eca32d25721dffb228b009bfbe415d5.tar.gz postgresql-67445deb7eca32d25721dffb228b009bfbe415d5.zip | |
Add missing exit() in pg_verifybackup when failing to find pg_waldump
pg_verifybackup needs by default pg_waldump to check after a range of
WAL segments required for a backup, except if --no-parse-wal is
specified. The code checked for the presence of the binary pg_waldump
in an installation and reported an error, but it forgot to properly
exit(). This could lead to confusing errors reported.
Reviewed-by: Robert Haas, Fabien Coelho
Discussion: https://postgr.es/m/YQDMdB+B68yePFeT@paquier.xyz
Backpatch-through: 13
| -rw-r--r-- | src/bin/pg_verifybackup/pg_verifybackup.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/bin/pg_verifybackup/pg_verifybackup.c b/src/bin/pg_verifybackup/pg_verifybackup.c index f5ebd57a47f..bb93b43093d 100644 --- a/src/bin/pg_verifybackup/pg_verifybackup.c +++ b/src/bin/pg_verifybackup/pg_verifybackup.c @@ -304,6 +304,7 @@ main(int argc, char **argv) "but was not the same version as %s.\n" "Check your installation.", "pg_waldump", full_path, "pg_verifybackup"); + exit(1); } } |