diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2020-06-09 01:17:59 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2020-06-09 01:18:35 -0400 |
| commit | 6df8fb391b0b98efc917b5cc43de77cba785864a (patch) | |
| tree | c7e1379260378c64fa25f0ce0ae4136adc33716e | |
| parent | 2174d40117f62099c7b11a2d43d163b7b9271d39 (diff) | |
| download | postgresql-6df8fb391b0b98efc917b5cc43de77cba785864a.tar.gz postgresql-6df8fb391b0b98efc917b5cc43de77cba785864a.zip | |
Repair unstable regression test.
Commit 0c882e52a tried to force table atest12 to have more-accurate-
than-default statistics; but transiently setting default_statistics_target
isn't enough for that, because autovacuum could come along and overwrite
the stats later. This evidently explains some intermittent buildfarm
failures we've seen since then. Repair by disabling autovac on this table.
Thanks to David Rowley for correctly diagnosing the cause.
Discussion: https://postgr.es/m/CA+hUKG+OUkQSOUTg=qo=S=fWa_tbm99i7rB7mfbHz1SYm4v-jQ@mail.gmail.com
| -rw-r--r-- | src/test/regress/expected/privileges.out | 3 | ||||
| -rw-r--r-- | src/test/regress/sql/privileges.sql | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/src/test/regress/expected/privileges.out b/src/test/regress/expected/privileges.out index 7caf0c9b6b9..3ec22c20ea1 100644 --- a/src/test/regress/expected/privileges.out +++ b/src/test/regress/expected/privileges.out @@ -191,7 +191,8 @@ CREATE TABLE atest12 as SELECT x AS a, 10001 - x AS b FROM generate_series(1,10000) x; CREATE INDEX ON atest12 (a); CREATE INDEX ON atest12 (abs(a)); --- results below depend on having quite accurate stats for atest12 +-- results below depend on having quite accurate stats for atest12, so... +ALTER TABLE atest12 SET (autovacuum_enabled = off); SET default_statistics_target = 10000; VACUUM ANALYZE atest12; RESET default_statistics_target; diff --git a/src/test/regress/sql/privileges.sql b/src/test/regress/sql/privileges.sql index 0ab5245b1eb..3550f61587a 100644 --- a/src/test/regress/sql/privileges.sql +++ b/src/test/regress/sql/privileges.sql @@ -136,7 +136,8 @@ CREATE TABLE atest12 as SELECT x AS a, 10001 - x AS b FROM generate_series(1,10000) x; CREATE INDEX ON atest12 (a); CREATE INDEX ON atest12 (abs(a)); --- results below depend on having quite accurate stats for atest12 +-- results below depend on having quite accurate stats for atest12, so... +ALTER TABLE atest12 SET (autovacuum_enabled = off); SET default_statistics_target = 10000; VACUUM ANALYZE atest12; RESET default_statistics_target; |