diff options
| author | Michael Paquier <michael@paquier.xyz> | 2021-06-26 12:39:54 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2021-06-26 12:39:54 +0900 |
| commit | 704e1dbd9aa29a0b46c356f1803ad55cbdef2c20 (patch) | |
| tree | 79a3e9bb31408ea718d6064b4f5611db53cf1d5e | |
| parent | 5a0f1c8c0193f0dd7fba50c22d96781fa2414007 (diff) | |
| download | postgresql-704e1dbd9aa29a0b46c356f1803ad55cbdef2c20.tar.gz postgresql-704e1dbd9aa29a0b46c356f1803ad55cbdef2c20.zip | |
Remove some useless logs from the TAP tests of pgbench
002_pgbench_no_server was printing some array pointers instead of the
actual contents of those arrays for the expected outputs of stdout and
stderr for a tested command. This does not add any new information that
can help with debugging as the test names allow to track failure
locations, if any.
This commit simply removes those logs as the rest of the printed
information is redundant with command_checks_all().
Per discussion with Andrew Dunstan and Álvaro Herrera.
Discussion: https://postgr.es/m/YNXNFaG7IgkzZanD@paquier.xyz
Backpatch-through: 11
| -rw-r--r-- | src/bin/pgbench/t/002_pgbench_no_server.pl | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/bin/pgbench/t/002_pgbench_no_server.pl b/src/bin/pgbench/t/002_pgbench_no_server.pl index 9023fac52d5..346a2667fca 100644 --- a/src/bin/pgbench/t/002_pgbench_no_server.pl +++ b/src/bin/pgbench/t/002_pgbench_no_server.pl @@ -26,7 +26,6 @@ sub pgbench local $Test::Builder::Level = $Test::Builder::Level + 1; my ($opts, $stat, $out, $err, $name) = @_; - print STDERR "opts=$opts, stat=$stat, out=$out, err=$err, name=$name"; command_checks_all([ 'pgbench', split(/\s+/, $opts) ], $stat, $out, $err, $name); return; |