diff options
| author | Fujii Masao <fujii@postgresql.org> | 2016-08-01 17:36:14 +0900 |
|---|---|---|
| committer | Fujii Masao <fujii@postgresql.org> | 2016-08-01 17:36:14 +0900 |
| commit | 74d8c95b7456faefdd4244acf854361711fb42ce (patch) | |
| tree | f5384a1876e193004c57c45e9deb5c411090de03 | |
| parent | 11653cd87f66fc55ab79683a3ba7e6fe1a299596 (diff) | |
| download | postgresql-74d8c95b7456faefdd4244acf854361711fb42ce.tar.gz postgresql-74d8c95b7456faefdd4244acf854361711fb42ce.zip | |
Fix pg_basebackup so that it accepts 0 as a valid compression level.
The help message for pg_basebackup specifies that the numbers 0 through 9
are accepted as valid values of -Z option. But, previously -Z 0 was rejected
as an invalid compression level.
Per discussion, it's better to make pg_basebackup treat 0 as valid
compression level meaning no compression, like pg_dump.
Back-patch to all supported versions.
Reported-By: Jeff Janes
Reviewed-By: Amit Kapila
Discussion: CAMkU=1x+GwjSayc57v6w87ij6iRGFWt=hVfM0B64b1_bPVKRqg@mail.gmail.com
| -rw-r--r-- | doc/src/sgml/ref/pg_basebackup.sgml | 2 | ||||
| -rw-r--r-- | src/bin/pg_basebackup/pg_basebackup.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/doc/src/sgml/ref/pg_basebackup.sgml b/doc/src/sgml/ref/pg_basebackup.sgml index 4d679d0a059..03615da480c 100644 --- a/doc/src/sgml/ref/pg_basebackup.sgml +++ b/doc/src/sgml/ref/pg_basebackup.sgml @@ -364,7 +364,7 @@ PostgreSQL documentation <listitem> <para> Enables gzip compression of tar file output, and specifies the - compression level (1 through 9, 9 being best + compression level (0 through 9, 0 being no compression and 9 being best compression). Compression is only available when using the tar format. </para> diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c index ec69682d208..ed41db8e6e6 100644 --- a/src/bin/pg_basebackup/pg_basebackup.c +++ b/src/bin/pg_basebackup/pg_basebackup.c @@ -2073,7 +2073,7 @@ main(int argc, char **argv) break; case 'Z': compresslevel = atoi(optarg); - if (compresslevel <= 0 || compresslevel > 9) + if (compresslevel < 0 || compresslevel > 9) { fprintf(stderr, _("%s: invalid compression level \"%s\"\n"), progname, optarg); |