diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2022-06-14 18:16:46 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2022-06-14 18:16:46 -0400 |
| commit | 7bc21ed8c8e755ef6fe41dae60c198fcc9c9ee56 (patch) | |
| tree | ef20bab6b704b82222475d3974bcb79a42950bc8 | |
| parent | be35a6456901cfdf4df91697370dc5edac7e58c5 (diff) | |
| download | postgresql-7bc21ed8c8e755ef6fe41dae60c198fcc9c9ee56.tar.gz postgresql-7bc21ed8c8e755ef6fe41dae60c198fcc9c9ee56.zip | |
Avoid ecpglib core dump with out-of-order operations.
If an application executed operations like EXEC SQL PREPARE
without having first established a database connection, it could
get a core dump instead of the expected clean failure. This
occurred because we did "pthread_getspecific(actual_connection_key)"
without ever having initialized the TSD key actual_connection_key.
The results of that are probably platform-specific, but at least
on Linux it often leads to a crash.
To fix, add calls to ecpg_pthreads_init() in the code paths that
might use actual_connection_key uninitialized. It's harmless
(and hopefully inexpensive) to do that more than once.
Per bug #17514 from Okano Naoki. The problem's ancient, so
back-patch to all supported branches.
Discussion: https://postgr.es/m/17514-edd4fad547c5692c@postgresql.org
| -rw-r--r-- | src/interfaces/ecpg/ecpglib/connect.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/src/interfaces/ecpg/ecpglib/connect.c b/src/interfaces/ecpg/ecpglib/connect.c index a2166b1e12f..15e6bbe36bb 100644 --- a/src/interfaces/ecpg/ecpglib/connect.c +++ b/src/interfaces/ecpg/ecpglib/connect.c @@ -40,6 +40,8 @@ ecpg_get_connection_nr(const char *connection_name) if ((connection_name == NULL) || (strcmp(connection_name, "CURRENT") == 0)) { #ifdef ENABLE_THREAD_SAFETY + ecpg_pthreads_init(); /* ensure actual_connection_key is valid */ + ret = pthread_getspecific(actual_connection_key); /* @@ -47,8 +49,7 @@ ecpg_get_connection_nr(const char *connection_name) * connection and hope the user knows what they're doing (i.e. using * their own mutex to protect that connection from concurrent accesses */ - /* if !ret then we got the connection from TSD */ - if (NULL == ret) + if (ret == NULL) /* no TSD connection, going for global */ ret = actual_connection; #else @@ -78,6 +79,8 @@ ecpg_get_connection(const char *connection_name) if ((connection_name == NULL) || (strcmp(connection_name, "CURRENT") == 0)) { #ifdef ENABLE_THREAD_SAFETY + ecpg_pthreads_init(); /* ensure actual_connection_key is valid */ + ret = pthread_getspecific(actual_connection_key); /* @@ -85,8 +88,7 @@ ecpg_get_connection(const char *connection_name) * connection and hope the user knows what they're doing (i.e. using * their own mutex to protect that connection from concurrent accesses */ - /* if !ret then we got the connection from TSD */ - if (NULL == ret) + if (ret == NULL) /* no TSD connection here either, using global */ ret = actual_connection; #else |