diff options
| author | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2010-11-09 17:40:09 +0200 |
|---|---|---|
| committer | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2010-11-09 17:48:43 +0200 |
| commit | 7c0af833c64cb9ab7fd78b10ec7b04e0b0874bcd (patch) | |
| tree | a425a6f1266b133b090def8de59ba9ba8f9463a9 | |
| parent | 658a630ac0ba0c79e026415d1571707b74069ddc (diff) | |
| download | postgresql-7c0af833c64cb9ab7fd78b10ec7b04e0b0874bcd.tar.gz postgresql-7c0af833c64cb9ab7fd78b10ec7b04e0b0874bcd.zip | |
In rewriteheap.c (used by VACUUM FULL and CLUSTER), calculate the tuple
length stored in the line pointer the same way it's calculated in the normal
heap_insert() codepath. As noted by Jeff Davis, the length stored by
raw_heap_insert() included padding but the one stored by the normal codepath
did not. While the mismatch seems to be harmless, inconsistency isn't good,
and the normal codepath has received a lot more testing over the years.
Backpatch to 8.3 where the heap rewrite code was introduced.
| -rw-r--r-- | src/backend/access/heap/rewriteheap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/access/heap/rewriteheap.c b/src/backend/access/heap/rewriteheap.c index 6f00c24845f..4a8fe8d36ef 100644 --- a/src/backend/access/heap/rewriteheap.c +++ b/src/backend/access/heap/rewriteheap.c @@ -636,7 +636,7 @@ raw_heap_insert(RewriteState state, HeapTuple tup) } /* And now we can insert the tuple into the page */ - newoff = PageAddItem(page, (Item) heaptup->t_data, len, + newoff = PageAddItem(page, (Item) heaptup->t_data, heaptup->t_len, InvalidOffsetNumber, false, true); if (newoff == InvalidOffsetNumber) elog(ERROR, "failed to add tuple"); |