aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Paquier <michael@paquier.xyz>2024-12-23 14:46:49 +0900
committerMichael Paquier <michael@paquier.xyz>2024-12-23 14:46:49 +0900
commit7f97b4734f937db6f8dab1bbf8bbaab349e6c9b1 (patch)
tree3827f44eae03b923f80f297e3d5c5efa442fbc45
parent578a7fe7b6f8484f6d7caa2fda288abb3fe87aa0 (diff)
downloadpostgresql-7f97b4734f937db6f8dab1bbf8bbaab349e6c9b1.tar.gz
postgresql-7f97b4734f937db6f8dab1bbf8bbaab349e6c9b1.zip
Fix some comments related to library unloading
Library unloading has never been supported with its code removed in ab02d702ef08, and there were some comments still mentioning that it was a possible operation. ChangAo has noticed the incorrect references in dfmgr.c, while I have noticed the other ones while scanning the rest of the tree for similar mistakes. Author: ChangAo Chen, Michael Paquier Reviewed-by: Tom Lane Discussion: https://postgr.es/m/tencent_1D09840A1632D406A610C8C4E2491D74DB0A@qq.com
-rw-r--r--contrib/auto_explain/auto_explain.c2
-rw-r--r--contrib/passwordcheck/passwordcheck.c2
-rw-r--r--contrib/pg_stat_statements/pg_stat_statements.c2
-rw-r--r--contrib/sepgsql/hooks.c2
-rw-r--r--src/backend/utils/fmgr/dfmgr.c4
5 files changed, 6 insertions, 6 deletions
diff --git a/contrib/auto_explain/auto_explain.c b/contrib/auto_explain/auto_explain.c
index f2eaa8e4949..4d87ea808e7 100644
--- a/contrib/auto_explain/auto_explain.c
+++ b/contrib/auto_explain/auto_explain.c
@@ -70,7 +70,7 @@ static bool current_query_sampled = false;
(nesting_level == 0 || auto_explain_log_nested_statements) && \
current_query_sampled)
-/* Saved hook values in case of unload */
+/* Saved hook values */
static ExecutorStart_hook_type prev_ExecutorStart = NULL;
static ExecutorRun_hook_type prev_ExecutorRun = NULL;
static ExecutorFinish_hook_type prev_ExecutorFinish = NULL;
diff --git a/contrib/passwordcheck/passwordcheck.c b/contrib/passwordcheck/passwordcheck.c
index 0785618f2ab..b5d95b558e9 100644
--- a/contrib/passwordcheck/passwordcheck.c
+++ b/contrib/passwordcheck/passwordcheck.c
@@ -26,7 +26,7 @@
PG_MODULE_MAGIC;
-/* Saved hook value in case of unload */
+/* Saved hook value */
static check_password_hook_type prev_check_password_hook = NULL;
/* passwords shorter than this will be rejected */
diff --git a/contrib/pg_stat_statements/pg_stat_statements.c b/contrib/pg_stat_statements/pg_stat_statements.c
index 602cae54ffd..7b3dd137b8f 100644
--- a/contrib/pg_stat_statements/pg_stat_statements.c
+++ b/contrib/pg_stat_statements/pg_stat_statements.c
@@ -256,7 +256,7 @@ typedef struct pgssSharedState
/* Current nesting depth of planner/ExecutorRun/ProcessUtility calls */
static int nesting_level = 0;
-/* Saved hook values in case of unload */
+/* Saved hook values */
static shmem_request_hook_type prev_shmem_request_hook = NULL;
static shmem_startup_hook_type prev_shmem_startup_hook = NULL;
static post_parse_analyze_hook_type prev_post_parse_analyze_hook = NULL;
diff --git a/contrib/sepgsql/hooks.c b/contrib/sepgsql/hooks.c
index 0f206b1093d..edf5206aa8b 100644
--- a/contrib/sepgsql/hooks.c
+++ b/contrib/sepgsql/hooks.c
@@ -394,7 +394,7 @@ sepgsql_utility_command(PlannedStmt *pstmt,
}
/*
- * Module load/unload callback
+ * Module load callback
*/
void
_PG_init(void)
diff --git a/src/backend/utils/fmgr/dfmgr.c b/src/backend/utils/fmgr/dfmgr.c
index 8e81ecc7491..8b7807472fd 100644
--- a/src/backend/utils/fmgr/dfmgr.c
+++ b/src/backend/utils/fmgr/dfmgr.c
@@ -125,7 +125,7 @@ load_external_function(const char *filename, const char *funcname,
/*
* This function loads a shlib file without looking up any particular
* function in it. If the same shlib has previously been loaded,
- * unload and reload it.
+ * we do not load it again.
*
* When 'restricted' is true, only libraries in the presumed-secure
* directory $libdir/plugins may be referenced.
@@ -142,7 +142,7 @@ load_file(const char *filename, bool restricted)
/* Expand the possibly-abbreviated filename to an exact path name */
fullname = expand_dynamic_library_name(filename);
- /* Load the shared library */
+ /* Load the shared library, unless we already did */
(void) internal_load_library(fullname);
pfree(fullname);