diff options
| author | Peter Geoghegan <pg@bowt.ie> | 2021-01-04 19:46:11 -0800 |
|---|---|---|
| committer | Peter Geoghegan <pg@bowt.ie> | 2021-01-04 19:46:11 -0800 |
| commit | 83e3239ee77089f76fad022eeef91c83cdf9181d (patch) | |
| tree | a92d3255ee86c913a678a5572e16ff00abbecbd7 | |
| parent | cd357c76296e987298e4005b8053adda9e3fb417 (diff) | |
| download | postgresql-83e3239ee77089f76fad022eeef91c83cdf9181d.tar.gz postgresql-83e3239ee77089f76fad022eeef91c83cdf9181d.zip | |
Standardize one aspect of rmgr desc output.
Bring heap and hash rmgr desc output in line with nbtree and GiST desc
output by using the name latestRemovedXid for all fields that output the
contents of the latestRemovedXid field from the WAL record's C struct
(stop using local variants).
This seems like a clear improvement because latestRemovedXid is a symbol
name that already appears across many different source files, and so is
probably much more recognizable.
Discussion: https://postgr.es/m/CAH2-Wzkt_Rs4VqPSCk87nyjPAAEmWL8STU9zgET_83EF5YfrLw@mail.gmail.com
| -rw-r--r-- | src/backend/access/rmgrdesc/hashdesc.c | 2 | ||||
| -rw-r--r-- | src/backend/access/rmgrdesc/heapdesc.c | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/backend/access/rmgrdesc/hashdesc.c b/src/backend/access/rmgrdesc/hashdesc.c index 55de27840d9..90ccea08e2c 100644 --- a/src/backend/access/rmgrdesc/hashdesc.c +++ b/src/backend/access/rmgrdesc/hashdesc.c @@ -113,7 +113,7 @@ hash_desc(StringInfo buf, XLogReaderState *record) { xl_hash_vacuum_one_page *xlrec = (xl_hash_vacuum_one_page *) rec; - appendStringInfo(buf, "ntuples %d, latest removed xid %u", + appendStringInfo(buf, "ntuples %d, latestRemovedXid %u", xlrec->ntuples, xlrec->latestRemovedXid); break; diff --git a/src/backend/access/rmgrdesc/heapdesc.c b/src/backend/access/rmgrdesc/heapdesc.c index 871c7a155e8..e60e32b9353 100644 --- a/src/backend/access/rmgrdesc/heapdesc.c +++ b/src/backend/access/rmgrdesc/heapdesc.c @@ -125,7 +125,7 @@ heap2_desc(StringInfo buf, XLogReaderState *record) { xl_heap_clean *xlrec = (xl_heap_clean *) rec; - appendStringInfo(buf, "remxid %u", xlrec->latestRemovedXid); + appendStringInfo(buf, "latestRemovedXid %u", xlrec->latestRemovedXid); } else if (info == XLOG_HEAP2_FREEZE_PAGE) { @@ -138,7 +138,7 @@ heap2_desc(StringInfo buf, XLogReaderState *record) { xl_heap_cleanup_info *xlrec = (xl_heap_cleanup_info *) rec; - appendStringInfo(buf, "remxid %u", xlrec->latestRemovedXid); + appendStringInfo(buf, "latestRemovedXid %u", xlrec->latestRemovedXid); } else if (info == XLOG_HEAP2_VISIBLE) { |