diff options
| author | Thomas Munro <tmunro@postgresql.org> | 2021-08-13 10:38:22 +1200 |
|---|---|---|
| committer | Thomas Munro <tmunro@postgresql.org> | 2021-08-13 11:09:00 +1200 |
| commit | 88cbbbfa3e2b0d38d6047af83764f140face5991 (patch) | |
| tree | 1ef9db7755eace29e68329fc4eb6a19fbe205738 | |
| parent | 650663b4cb4714a34d7171981de4392486a85f86 (diff) | |
| download | postgresql-88cbbbfa3e2b0d38d6047af83764f140face5991.tar.gz postgresql-88cbbbfa3e2b0d38d6047af83764f140face5991.zip | |
Make EXEC_BACKEND more convenient on macOS.
It's hard to disable ASLR on current macOS releases, for testing with
-DEXEC_BACKEND. You could already set the environment variable
PG_SHMEM_ADDR to something not likely to collide with mappings created
earlier in process startup. Let's also provide a default value that
works on current releases and architectures, for developer convenience.
As noted in the pre-existing comment, this is a horrible hack, but
-DEXEC_BACKEND is only used by Unix-based PostgreSQL developers for
testing some otherwise Windows-only code paths, so it seems excusable.
Back-patch to all supported branches.
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/20210806032944.m4tz7j2w47mant26%40alap3.anarazel.de
| -rw-r--r-- | src/backend/port/sysv_shmem.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/src/backend/port/sysv_shmem.c b/src/backend/port/sysv_shmem.c index 0cc83ffc16a..9de96edf6ad 100644 --- a/src/backend/port/sysv_shmem.c +++ b/src/backend/port/sysv_shmem.c @@ -143,6 +143,16 @@ InternalIpcMemoryCreate(IpcMemoryKey memKey, Size size) if (pg_shmem_addr) requestedAddress = (void *) strtoul(pg_shmem_addr, NULL, 0); + else + { +#if defined(__darwin__) && SIZEOF_VOID_P == 8 + /* + * Provide a default value that is believed to avoid problems with + * ASLR on the current macOS release. + */ + requestedAddress = (void *) 0x80000000000; +#endif + } } #endif |