diff options
| author | Noah Misch <noah@leadboat.com> | 2022-08-05 08:30:58 -0700 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2022-08-05 08:30:58 -0700 |
| commit | 8ad6c5dbbe5a234c55c6663020db297251756006 (patch) | |
| tree | e99f8f10f3ff2e0868facf1c2ca4f877922a0c4c | |
| parent | 6d9481cd05d2a0d4152c02c5d48b7f7eb7b90a49 (diff) | |
| download | postgresql-8ad6c5dbbe5a234c55c6663020db297251756006.tar.gz postgresql-8ad6c5dbbe5a234c55c6663020db297251756006.zip | |
Add HINT for restartpoint race with KeepFileRestoredFromArchive().
The five commits ending at cc2c7d65fc27e877c9f407587b0b92d46cd6dd16
closed this race condition for v15+. For v14 through v10, add a HINT to
discourage studying the cosmetic problem.
Reviewed by Kyotaro Horiguchi and David Steele.
Discussion: https://postgr.es/m/20220731061747.GA3692882@rfd.leadboat.com
| -rw-r--r-- | src/backend/access/transam/xlog.c | 5 | ||||
| -rw-r--r-- | src/backend/storage/file/fd.c | 10 |
2 files changed, 12 insertions, 3 deletions
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 98854018989..ef72bde0123 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -3481,7 +3481,10 @@ XLogFileInit(XLogSegNo logsegno, bool *use_existent, bool use_lock) if (fd < 0) ereport(ERROR, (errcode_for_file_access(), - errmsg("could not open file \"%s\": %m", path))); + errmsg("could not open file \"%s\": %m", path), + (AmCheckpointerProcess() ? + errhint("This is known to fail occasionally during archive recovery, where it is harmless.") : + 0))); elog(DEBUG2, "done creating and filling new WAL file"); diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c index 6688dee2f42..e76daff4951 100644 --- a/src/backend/storage/file/fd.c +++ b/src/backend/storage/file/fd.c @@ -834,7 +834,10 @@ durable_rename_excl(const char *oldfile, const char *newfile, int elevel) ereport(elevel, (errcode_for_file_access(), errmsg("could not link file \"%s\" to \"%s\": %m", - oldfile, newfile))); + oldfile, newfile), + (AmCheckpointerProcess() ? + errhint("This is known to fail occasionally during archive recovery, where it is harmless.") : + 0))); return -1; } unlink(oldfile); @@ -844,7 +847,10 @@ durable_rename_excl(const char *oldfile, const char *newfile, int elevel) ereport(elevel, (errcode_for_file_access(), errmsg("could not rename file \"%s\" to \"%s\": %m", - oldfile, newfile))); + oldfile, newfile), + (AmCheckpointerProcess() ? + errhint("This is known to fail occasionally during archive recovery, where it is harmless.") : + 0))); return -1; } #endif |