diff options
| author | David Rowley <drowley@postgresql.org> | 2023-01-24 13:49:10 +1300 |
|---|---|---|
| committer | David Rowley <drowley@postgresql.org> | 2023-01-24 13:49:10 +1300 |
| commit | 9567686ec834e50ab10ae872a8394c9a9e590b0d (patch) | |
| tree | 9b90fa0575db2ad7fe74b41270bbba9297283bf5 | |
| parent | b762fed6481e722a022ac2bea02151e080c31fa6 (diff) | |
| download | postgresql-9567686ec834e50ab10ae872a8394c9a9e590b0d.tar.gz postgresql-9567686ec834e50ab10ae872a8394c9a9e590b0d.zip | |
Use OFFSET 0 instead of ORDER BY to stop subquery pullup
b762fed64 recently changed this test to prevent subquery pullup to allow
us to test Memoize with lateral_vars. As pointed out by Tom Lane, OFFSET
0 is our standard way of preventing subquery pullups, so do it that way
instead.
Discussion: https://postgr.es/m/2144818.1674517061@sss.pgh.pa.us
Backpatch-through: 14, same as b762fed64
| -rw-r--r-- | src/test/regress/expected/memoize.out | 4 | ||||
| -rw-r--r-- | src/test/regress/sql/memoize.sql | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/test/regress/expected/memoize.out b/src/test/regress/expected/memoize.out index 08719320376..60cbdeec7a8 100644 --- a/src/test/regress/expected/memoize.out +++ b/src/test/regress/expected/memoize.out @@ -64,7 +64,7 @@ WHERE t2.unique1 < 1000; SELECT explain_memoize(' SELECT COUNT(*),AVG(t2.unique1) FROM tenk1 t1, LATERAL (SELECT t2.unique1 FROM tenk1 t2 - WHERE t1.twenty = t2.unique1 ORDER BY 1) t2 + WHERE t1.twenty = t2.unique1 OFFSET 0) t2 WHERE t1.unique1 < 1000;', false); explain_memoize ------------------------------------------------------------------------------------------- @@ -85,7 +85,7 @@ WHERE t1.unique1 < 1000;', false); -- And check we get the expected results. SELECT COUNT(*),AVG(t2.unique1) FROM tenk1 t1, LATERAL (SELECT t2.unique1 FROM tenk1 t2 - WHERE t1.twenty = t2.unique1 ORDER BY 1) t2 + WHERE t1.twenty = t2.unique1 OFFSET 0) t2 WHERE t1.unique1 < 1000; count | avg -------+-------------------- diff --git a/src/test/regress/sql/memoize.sql b/src/test/regress/sql/memoize.sql index 623a9d5114f..d66acaed85a 100644 --- a/src/test/regress/sql/memoize.sql +++ b/src/test/regress/sql/memoize.sql @@ -48,13 +48,13 @@ WHERE t2.unique1 < 1000; SELECT explain_memoize(' SELECT COUNT(*),AVG(t2.unique1) FROM tenk1 t1, LATERAL (SELECT t2.unique1 FROM tenk1 t2 - WHERE t1.twenty = t2.unique1 ORDER BY 1) t2 + WHERE t1.twenty = t2.unique1 OFFSET 0) t2 WHERE t1.unique1 < 1000;', false); -- And check we get the expected results. SELECT COUNT(*),AVG(t2.unique1) FROM tenk1 t1, LATERAL (SELECT t2.unique1 FROM tenk1 t2 - WHERE t1.twenty = t2.unique1 ORDER BY 1) t2 + WHERE t1.twenty = t2.unique1 OFFSET 0) t2 WHERE t1.unique1 < 1000; -- Reduce work_mem and hash_mem_multiplier so that we see some cache evictions |