diff options
| author | Daniel Gustafsson <dgustafsson@postgresql.org> | 2024-04-03 13:33:25 +0200 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2024-09-24 12:10:30 +0900 |
| commit | 988ddbef978bb2f247f0e021a28527e3776d6906 (patch) | |
| tree | 5df972ff43975b8953fb021bbb6ce89c9df99065 | |
| parent | cf9f6b4688626e8d0682f96879325019d39c9794 (diff) | |
| download | postgresql-988ddbef978bb2f247f0e021a28527e3776d6906.tar.gz postgresql-988ddbef978bb2f247f0e021a28527e3776d6906.zip | |
Drop global objects after completed test
Project policy is to not leave global objects behind after a regress
test run. This was found as a result of the development of a patch
to make pg_regress detect such leftovers automatically, which in the
end was withdrawn due to issues with parallel runs.
This was originally committed as 936e3fa3787a, but the issue also exists
in the 12~16 range.
Discussion: https://postgr.es/m/E1phvk7-000VAH-7k@gemulon.postgresql.org
Backpatch-through: 12
| -rw-r--r-- | src/test/modules/test_pg_dump/expected/test_pg_dump.out | 2 | ||||
| -rw-r--r-- | src/test/modules/test_pg_dump/sql/test_pg_dump.sql | 4 |
2 files changed, 6 insertions, 0 deletions
diff --git a/src/test/modules/test_pg_dump/expected/test_pg_dump.out b/src/test/modules/test_pg_dump/expected/test_pg_dump.out index 8df7f090544..ea8daf01130 100644 --- a/src/test/modules/test_pg_dump/expected/test_pg_dump.out +++ b/src/test/modules/test_pg_dump/expected/test_pg_dump.out @@ -91,6 +91,8 @@ ALTER EXTENSION test_pg_dump DROP SERVER s0; ALTER EXTENSION test_pg_dump DROP TABLE test_pg_dump_t1; ALTER EXTENSION test_pg_dump DROP TYPE test_pg_dump_e1; ALTER EXTENSION test_pg_dump DROP VIEW test_pg_dump_v1; +DROP OWNED BY regress_dump_test_role RESTRICT; +DROP ROLE regress_dump_test_role; DROP EXTENSION test_pg_dump; -- shouldn't be anything left in pg_init_privs SELECT * FROM pg_init_privs WHERE privtype = 'e'; diff --git a/src/test/modules/test_pg_dump/sql/test_pg_dump.sql b/src/test/modules/test_pg_dump/sql/test_pg_dump.sql index 7f2e7d32f6d..5c0a3a2058b 100644 --- a/src/test/modules/test_pg_dump/sql/test_pg_dump.sql +++ b/src/test/modules/test_pg_dump/sql/test_pg_dump.sql @@ -107,6 +107,10 @@ ALTER EXTENSION test_pg_dump DROP TABLE test_pg_dump_t1; ALTER EXTENSION test_pg_dump DROP TYPE test_pg_dump_e1; ALTER EXTENSION test_pg_dump DROP VIEW test_pg_dump_v1; +DROP OWNED BY regress_dump_test_role RESTRICT; + +DROP ROLE regress_dump_test_role; + DROP EXTENSION test_pg_dump; -- shouldn't be anything left in pg_init_privs |