diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2010-08-18 15:21:54 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2010-08-18 15:21:54 +0000 |
| commit | 99848ed7cb06ca14ee06bfa5b521c43ea63001a2 (patch) | |
| tree | 0544e50d2447b6c87bcae7ed27c8a9cfb53c30cc | |
| parent | ef71375346f8eba52ab3ec8b360869f859c83f3e (diff) | |
| download | postgresql-99848ed7cb06ca14ee06bfa5b521c43ea63001a2.tar.gz postgresql-99848ed7cb06ca14ee06bfa5b521c43ea63001a2.zip | |
Add missing handling of PlannedStmt.transientPlan in copyfuncs/outfuncs.
_outPlannedStmt is only debug support, so the omission there was not very
serious, but the omission in _copyPlannedStmt is a real bug. The consequence
would be that a copied plan tree would never be marked as a transient plan,
so that we would forget we ought to replan it after some not-yet-ready index
becomes ready for use. This might explain some past complaints about indexes
created with CREATE INDEX CONCURRENTLY not being used right away. Problem
spotted by Yeb Havinga.
Back-patch to 8.3, where the field was added.
| -rw-r--r-- | src/backend/nodes/copyfuncs.c | 3 | ||||
| -rw-r--r-- | src/backend/nodes/outfuncs.c | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/src/backend/nodes/copyfuncs.c b/src/backend/nodes/copyfuncs.c index 54af8b62cac..70cd56a5921 100644 --- a/src/backend/nodes/copyfuncs.c +++ b/src/backend/nodes/copyfuncs.c @@ -15,7 +15,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/nodes/copyfuncs.c,v 1.467 2010/08/07 02:44:06 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/nodes/copyfuncs.c,v 1.468 2010/08/18 15:21:54 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -79,6 +79,7 @@ _copyPlannedStmt(PlannedStmt *from) COPY_SCALAR_FIELD(commandType); COPY_SCALAR_FIELD(hasReturning); COPY_SCALAR_FIELD(canSetTag); + COPY_SCALAR_FIELD(transientPlan); COPY_NODE_FIELD(planTree); COPY_NODE_FIELD(rtable); COPY_NODE_FIELD(resultRelations); diff --git a/src/backend/nodes/outfuncs.c b/src/backend/nodes/outfuncs.c index 8c694350950..bfa34ed14ca 100644 --- a/src/backend/nodes/outfuncs.c +++ b/src/backend/nodes/outfuncs.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/nodes/outfuncs.c,v 1.388 2010/08/07 02:44:06 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/nodes/outfuncs.c,v 1.389 2010/08/18 15:21:54 tgl Exp $ * * NOTES * Every node type that can appear in stored rules' parsetrees *must* @@ -244,6 +244,7 @@ _outPlannedStmt(StringInfo str, PlannedStmt *node) WRITE_ENUM_FIELD(commandType, CmdType); WRITE_BOOL_FIELD(hasReturning); WRITE_BOOL_FIELD(canSetTag); + WRITE_BOOL_FIELD(transientPlan); WRITE_NODE_FIELD(planTree); WRITE_NODE_FIELD(rtable); WRITE_NODE_FIELD(resultRelations); |