aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNoah Misch <noah@leadboat.com>2020-06-07 16:27:13 -0700
committerNoah Misch <noah@leadboat.com>2020-06-07 16:27:17 -0700
commit9b5f85fb0a3e27040bc72451893d2dc35bb5d8bd (patch)
tree61edc15db06deba5779446db3764e54c0ffbdfd8
parentb5d69b7c22ee4c44b8bb99cfa0466ffaf3b5fab9 (diff)
downloadpostgresql-9b5f85fb0a3e27040bc72451893d2dc35bb5d8bd.tar.gz
postgresql-9b5f85fb0a3e27040bc72451893d2dc35bb5d8bd.zip
MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS.
Commit 7be5d8df1f74b78620167d3abf32ee607e728919 surfaced the logic error, which had no functional implications, by adding "use warnings". The buildfarm always customizes PROVE_FLAGS, so the warning did not appear there. Back-patch to 9.5 (all supported versions).
-rw-r--r--src/tools/msvc/vcregress.pl2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl
index 0a98f6e37d5..4a53a004b78 100644
--- a/src/tools/msvc/vcregress.pl
+++ b/src/tools/msvc/vcregress.pl
@@ -198,7 +198,7 @@ sub tap_check
unless $config->{tap_tests};
my @flags;
- foreach my $arg (0 .. scalar(@_))
+ foreach my $arg (0 .. scalar(@_) - 1)
{
next unless $_[$arg] =~ /^PROVE_FLAGS=(.*)/;
@flags = split(/\s+/, $1);