diff options
| author | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2021-11-26 11:14:27 -0300 |
|---|---|---|
| committer | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2021-11-26 11:14:27 -0300 |
| commit | 9c6ab1ef338273850c8c33f808d27486d3c5ad76 (patch) | |
| tree | aea2eff1a8710c29e280886e3f3c6da97fbc0995 | |
| parent | 0d335cbd5c63009576280ff502b31a84e353a86b (diff) | |
| download | postgresql-9c6ab1ef338273850c8c33f808d27486d3c5ad76.tar.gz postgresql-9c6ab1ef338273850c8c33f808d27486d3c5ad76.zip | |
Fix determination of broken LSN in OVERWRITTEN_CONTRECORD
In commit ff9f111bce24 I mixed up inconsistent definitions of the LSN of
the first record in a page, when the previous record ends exactly at the
page boundary. The correct LSN is adjusted to skip the WAL page header;
I failed to use that when setting XLogReaderState->overwrittenRecPtr,
so at WAL replay time VerifyOverwriteContrecord would refuse to let
replay continue past that record.
Backpatch to 10. 9.6 also contains this bug, but it's no longer being
maintained.
Discussion: https://postgr.es/m/45597.1637694259@sss.pgh.pa.us
| -rw-r--r-- | src/backend/access/transam/xlogreader.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/access/transam/xlogreader.c b/src/backend/access/transam/xlogreader.c index 26bdd4c102e..26f8e0ae2c6 100644 --- a/src/backend/access/transam/xlogreader.c +++ b/src/backend/access/transam/xlogreader.c @@ -415,7 +415,7 @@ restart: */ if (pageHeader->xlp_info & XLP_FIRST_IS_OVERWRITE_CONTRECORD) { - state->overwrittenRecPtr = state->currRecPtr; + state->overwrittenRecPtr = RecPtr; ResetDecoder(state); RecPtr = targetPagePtr; goto restart; |