diff options
| author | Andrew Dunstan <andrew@dunslane.net> | 2023-03-12 09:00:32 -0400 |
|---|---|---|
| committer | Andrew Dunstan <andrew@dunslane.net> | 2023-03-12 09:03:19 -0400 |
| commit | 9e236f94367639308cff62a33bc1ed815cf0f50c (patch) | |
| tree | de11aa84ee5b5037669de2c7a409228cd8ec53e6 | |
| parent | e8a9750d03d70de4ecd5aee37971498d90aabca5 (diff) | |
| download | postgresql-9e236f94367639308cff62a33bc1ed815cf0f50c.tar.gz postgresql-9e236f94367639308cff62a33bc1ed815cf0f50c.zip | |
Mark unsafe_tests module as not runnable with installcheck
This was an omission in the original creation of the module.
Also slightly adjust some wording to avoid a double "is".
Backpatch the non-meson piece of this to release 12, where the module
was introduced.
Discussion: https://postgr.es/m/be869e1c-8e3f-4cde-8609-212c899cccf9@dunslane.net
| -rw-r--r-- | src/test/modules/unsafe_tests/Makefile | 3 | ||||
| -rw-r--r-- | src/test/modules/unsafe_tests/README | 2 |
2 files changed, 4 insertions, 1 deletions
diff --git a/src/test/modules/unsafe_tests/Makefile b/src/test/modules/unsafe_tests/Makefile index df582736884..90d19791871 100644 --- a/src/test/modules/unsafe_tests/Makefile +++ b/src/test/modules/unsafe_tests/Makefile @@ -2,6 +2,9 @@ REGRESS = rolenames alter_system_table guc_privs +# the whole point of these tests is to not run installcheck +NO_INSTALLCHECK = 1 + ifdef USE_PGXS PG_CONFIG = pg_config PGXS := $(shell $(PG_CONFIG) --pgxs) diff --git a/src/test/modules/unsafe_tests/README b/src/test/modules/unsafe_tests/README index a7e5b2a04f5..d9dbd038b95 100644 --- a/src/test/modules/unsafe_tests/README +++ b/src/test/modules/unsafe_tests/README @@ -1,6 +1,6 @@ This directory doesn't actually contain any extension module. -What it is is a home for regression tests that we don't want to run +Instead it is a home for regression tests that we don't want to run during "make installcheck" because they could have side-effects that seem undesirable for a production installation. |