diff options
| author | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2012-06-28 23:37:27 -0400 |
|---|---|---|
| committer | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2012-06-28 23:37:27 -0400 |
| commit | 9e26326ad6cd11ac32d11e6cbeb613443f361da6 (patch) | |
| tree | a98e09e7ba355f12530b2971e41c8a3b3bc2eae4 | |
| parent | c1494b733015bf09d75c362925ec3f2740a77f73 (diff) | |
| download | postgresql-9e26326ad6cd11ac32d11e6cbeb613443f361da6.tar.gz postgresql-9e26326ad6cd11ac32d11e6cbeb613443f361da6.zip | |
pg_upgrade: fix off-by-one mistake in snprintf
snprintf counts trailing NUL towards the char limit. Failing to account
for that was causing an invalid value to be passed to pg_resetxlog -l,
aborting the upgrade process.
| -rw-r--r-- | contrib/pg_upgrade/controldata.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/pg_upgrade/controldata.c b/contrib/pg_upgrade/controldata.c index 5d5ab854ca8..7da19c6c28b 100644 --- a/contrib/pg_upgrade/controldata.c +++ b/contrib/pg_upgrade/controldata.c @@ -425,7 +425,7 @@ get_control_data(ClusterInfo *cluster, bool live_check) { if (got_log_id && got_log_seg) { - snprintf(cluster->controldata.nextxlogfile, 24, "%08X%08X%08X", + snprintf(cluster->controldata.nextxlogfile, 25, "%08X%08X%08X", tli, logid, segno); got_nextxlogfile = true; } |