diff options
| author | Fujii Masao <fujii@postgresql.org> | 2021-07-29 01:30:02 +0900 |
|---|---|---|
| committer | Fujii Masao <fujii@postgresql.org> | 2021-07-29 01:31:41 +0900 |
| commit | a00c138b78521b9bc68b480490a8d601ecdeb816 (patch) | |
| tree | a301275ab4f6678fe19d9d51888032586c358c4c | |
| parent | 3ba70d4e152372fd8ab90ed0887ee08d505ef306 (diff) | |
| download | postgresql-a00c138b78521b9bc68b480490a8d601ecdeb816.tar.gz postgresql-a00c138b78521b9bc68b480490a8d601ecdeb816.zip | |
Update minimum recovery point on truncation during WAL replay of abort record.
If a file is truncated, we must update minRecoveryPoint. Once a file is
truncated, there's no going back; it would not be safe to stop recovery
at a point earlier than that anymore.
Commit 7bffc9b7bf changed xact_redo_commit() so that it updates
minRecoveryPoint on truncation, but forgot to change xact_redo_abort().
Back-patch to all supported versions.
Reported-by: mengjuan.cmj@alibaba-inc.com
Author: Fujii Masao
Reviewed-by: Heikki Linnakangas
Discussion: https://postgr.es/m/b029fce3-4fac-4265-968e-16f36ff4d075.mengjuan.cmj@alibaba-inc.com
| -rw-r--r-- | src/backend/access/transam/xact.c | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c index 441445927e8..387f80419a5 100644 --- a/src/backend/access/transam/xact.c +++ b/src/backend/access/transam/xact.c @@ -5983,7 +5983,16 @@ xact_redo_abort(xl_xact_parsed_abort *parsed, TransactionId xid, } /* Make sure files supposed to be dropped are dropped */ - DropRelationFiles(parsed->xnodes, parsed->nrels, true); + if (parsed->nrels > 0) + { + /* + * See comments about update of minimum recovery point on truncation, + * in xact_redo_commit(). + */ + XLogFlush(lsn); + + DropRelationFiles(parsed->xnodes, parsed->nrels, true); + } } void |